Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crosscluster/logical: use large test pool #139955

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

msbutler
Copy link
Collaborator

This package spins up several TestServers. We've also seen many tests timeout, likely due to resource exhaustion.

Informs #138277
Informs #139673

Release note: none

@msbutler msbutler added T-disaster-recovery backport-24.3.x Flags PRs that need to be backported to 24.3 backport-25.1.x Flags PRs that need to be backported to 25.1 labels Jan 28, 2025
@msbutler msbutler requested a review from rickystewart January 28, 2025 16:50
@msbutler msbutler self-assigned this Jan 28, 2025
@msbutler msbutler requested a review from a team as a code owner January 28, 2025 16:50
@msbutler msbutler requested review from kev-cao and removed request for a team January 28, 2025 16:50
@cockroach-teamcity
Copy link
Member

This change is Reviewable

This package spins up several TestServers. We've also seen many tests timeout,
likely due to resource exhaustion.

Informs cockroachdb#138277
Informs cockroachdb#139673

Release note: none
@msbutler
Copy link
Collaborator Author

@rickystewart could you confirm that i'm not going to blow anything up with this patch? thanks!

@msbutler
Copy link
Collaborator Author

TFTR!

bors r=rickystewart

@craig craig bot merged commit 281a25b into cockroachdb:master Jan 31, 2025
22 checks passed
Copy link

blathers-crl bot commented Jan 31, 2025

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 0d07ed8 to blathers/backport-release-24.3-139955: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.3.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-24.3.x Flags PRs that need to be backported to 24.3 backport-25.1.x Flags PRs that need to be backported to 25.1 T-disaster-recovery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants