Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: sql: min row count 1 plus unbounded cardinality flag #139952

Closed

Conversation

mgartner
Copy link
Collaborator

No description provided.

Copy link

blathers-crl bot commented Jan 28, 2025

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regression in TPC-C is a little concerning... otherwise looks good

Reviewed 2 of 37 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @mgartner)


pkg/sql/opt/xform/testdata/external/tpcc line 763 at r1 (raw file):

           │    └── fd: ()-->(2,3), (1)-->(4-6,17)
           └── filters
                └── c_last:6 = 'Smith' [outer=(6), constraints=(/6: [/'Smith' - /'Smith']; tight), fd=()-->(6)]

This looks like a regression


pkg/sql/opt/xform/testdata/physprops/ordering line 3023 at r1 (raw file):

           │    └── filters
           │         └── tab_171968.col1_3 = tab_171969.col1_3
           └── filters (true)

Also looks like it might be a regression

@mgartner
Copy link
Collaborator Author

mgartner commented Jan 29, 2025

Closing in favor of #140065 and #139985.

@rytaft pointed out some regressions above that we should be mindful of if we enable this setting by default.

@mgartner mgartner closed this Jan 29, 2025
@mgartner mgartner deleted the row-count-1-plus-unbounded branch January 29, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants