Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-25.1: crosscluster/physical: remove TestTenantStreamingMultipleNodes #139949

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jan 28, 2025

Backport 1/1 commits from #139784 on behalf of @msbutler.

/cc @cockroachdb/release


The test takes 30 seconds to run on a good day, and the roachtest suite already covers everything this tests.

Fixes #136786

Release note: none


Release justification:

The test takes 30 seconds to run on a good day, and the roachtest suite already
covers everything this tests.

Fixes #136786

Release note: none
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-25.1-139784 branch from e9f0bad to bd094ad Compare January 28, 2025 16:16
@blathers-crl blathers-crl bot requested a review from a team as a code owner January 28, 2025 16:16
@blathers-crl blathers-crl bot requested review from kev-cao and removed request for a team January 28, 2025 16:16
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jan 28, 2025
@blathers-crl blathers-crl bot requested a review from jeffswenson January 28, 2025 16:16
Copy link
Author

blathers-crl bot commented Jan 28, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jan 28, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@jeffswenson jeffswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msbutler msbutler merged commit bdb558b into release-25.1 Jan 31, 2025
18 of 20 checks passed
@msbutler msbutler deleted the blathers/backport-release-25.1-139784 branch January 31, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants