sqlstats: add batching to flush operation #139608
Open
+280
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would process each persisted stat row insert as a separate transaction. This incurred lots of transaction teardown/setup costs over the life of the flush operation. This change modifies the flush to batch the inserts in groups of 100 (arbitrarily chosen, for now). The batches are iterated over using a small struct that constructs the batch slices from the list of stats. The rest of the operation remains as-is except the SQL transaction is moved upwards in the callstack to contain all the elements in a single batch. Resolves: cockroachdb#139143 Release note: None
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would process each persisted stat row insert as a separate transaction. This incurred lots of transaction teardown/setup costs over the life of the flush operation.
This change modifies the flush to batch the inserts in groups of 100 (arbitrarily chosen, for now). The batches are iterated over using a small struct that constructs the batch slices from the list of stats. The rest of the operation remains as-is except the SQL transaction is moved upwards in the callstack to contain all the elements in a single batch.
Resolves: #139143
Release note: None