Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: plumb vector search into execution logic #138797

Closed
wants to merge 3 commits into from

Conversation

DrewKimball
Copy link
Collaborator

No description provided.

Copy link

blathers-crl bot commented Jan 10, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

This commit renames the `VectorPartitionSearch` operator to
`VectorMutationSearch`. This reflects the fact that the operator is
used to prepare the information needed for index updates.

Epic: None

Release note: None
This commit changes `VectorMutationSearch` so that it produces quantized
and encoded vectors, rather than partition centroids. This shifts the
responsibility of quantizing vectors to the `VectorMutationSearch`
operator rather than the insert/update code paths.

Epic: CRDB-42943

Release note: None
Copy link

blathers-crl bot commented Jan 22, 2025

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@DrewKimball
Copy link
Collaborator Author

Closing in favor of #140770 as the source of truth for unmerged work.

@DrewKimball DrewKimball closed this Feb 8, 2025
@DrewKimball DrewKimball deleted the vector-exec branch February 8, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants