upgrades: set exclude_data_from_backup on non-system tenants #129669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
renatolabs
force-pushed
the
rc/system-schema-tenants-exclude-data-from-backup
branch
from
9695709 to
aba2705
Compare
rafiss
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
thank you for taking care of this!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @stevendanna)
This commit adds a new migration to set `exclude_data_from_backup` on tenant system tables with low GC TTL, as was done for the system tenant in cockroachdb#120144. Fixes: cockroachdb#129643 Release note: None
renatolabs
force-pushed
the
rc/system-schema-tenants-exclude-data-from-backup
branch
from
aba2705 to
3d9e7da
Compare
|
TFTR! bors r=rafiss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new migration to set
exclude_data_from_backupon tenant system tables with low GC TTL, as was done for the system tenant in #120144.Fixes: #129643
Release note: None