rac2,replica_rac2: implement Processor.AdmitForEval #129573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
sumeerbhola
commented
Aug 23, 2024
There was a problem hiding this comment.
First commit is from #129521
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @kvoli and @pav-kv)
sumeerbhola
force-pushed
the
proc_eval
branch
2 times, most recently
from
c1fab20 to
b622045
Compare
kvoli
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Reviewed 7 of 7 files at r2, all commit messages.
Reviewable status:
|
TFTR! |
|
bors r=kvoli |
|
Build failed: |
sumeerbhola
force-pushed
the
proc_eval
branch
2 times, most recently
from
8df85f5 to
bb0b5f4
Compare
|
bors r=kvoli |
|
Build failed: |
- RangeController.WaitForEval is changed to additionally return a waited bool, so that it conforms to the callers expectation that (false, nil) will be returned when the RangeController is closed during waiting. This allows the caller to wait on the local store (before eval) and not completely bypass all AC. - Processor.AdmitForEval consults the existing kvadmission.flow_control.mode cluster setting to decide whether a request should be subject to replication AC, and if yes, forwards to the RangeController. Fixes cockroachdb#129522 Epic: CRDB-37515 Release note: None
|
bors r=kvoli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bool, so that it conforms to the callers expectation that (false, nil)
will be returned when the RangeController is closed during waiting.
This allows the caller to wait on the local store (before eval) and
not completely bypass all AC.
kvadmission.flow_control.mode cluster setting to decide whether a
request should be subject to replication AC, and if yes, forwards to
the RangeController.
Fixes #129522
Epic: CRDB-37515
Release note: None