release-23.2: cluster-ui: fix insights page crash #120210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
When the Schema Insights Type is unitialized, the Schema Insights tab would crash because a string method was being called on `undefined`. The types are all correct, but because strict mode isn't enabled, it's not considered a type error. Now the string method is only called if the Schema Insights Type is defined. The same type issue that was fixed for `filters.schemaInsightType` was fixed for all other filters in the same file as well. Fixes: https://cockroachlabs.atlassian.net/browse/CC-27391 Release note (bug fix): Fixes intermittent page crash on the Schema Insights view.
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.2-120137
branch
from
7398253 to
1f3d096
Compare
blathers-crl
bot
added
blathers-backport
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
|
This change is |
This bug fix needs to be pulled into CC Console, so publishing is required. Epic: none Release note: None
rgcase
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
LGTM seems very low risk.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @dhartunian, @laurenbarker, and @xinhaoz)
dhartunian
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Reviewable status:
|
TFTRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #120137 on behalf of @laurenbarker.
/cc @cockroachdb/release
When the Schema Insights Type is uninitialized, the Schema Insights tab would crash because a string method was being called on
undefined. The types are all correct, but because strict mode isn't enabled, it's not considered a type error.Now the string method is only called if the Schema Insights Type is defined.
Fixes: https://cockroachlabs.atlassian.net/browse/CC-27391
Release note (bug fix): Fixes intermittent page crash on the Schema Insights view.
Release justification: Without this fix, the Schema Insights page occasionally crashes and customers are unable to see any schema insights. Backporting also keeps DB Console and CC Console in sync.