roachprod: only register services when applicable #120141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
herkolategan
force-pushed
the
hbl/roachprod-dns-limits
branch
from
3c42e93 to
a5f56f1
Compare
herkolategan
requested review from
srosenberg and
renatolabs
and removed request for
a team
herkolategan
force-pushed
the
hbl/roachprod-dns-limits
branch
6 times, most recently
from
6f91a73 to
6e296c9
Compare
Previously, DNS services for clusters would be registered in all cases. This can lead to some scenarios where `roachprod` is unable to correctly determine the port of a service. When a cluster is created in a custom GCP project (non-default project) the `roachprod` garbage collector will destroy the records as it determines it has nothing to tie the resources to since it has no visibility of the custom project. As we currently do not test virtual clusters on AWS or Azure, these have also been excluded, because these providers do not specify using the Google Cloud DNS Provider yet. For that reason, there is no point in trying to register services. Epic: None Release Note: None
herkolategan
force-pushed
the
hbl/roachprod-dns-limits
branch
from
6e296c9 to
d297e43
Compare
renatolabs
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @srosenberg)
srosenberg
approved these changes
Mar 10, 2024
|
TFTRs! bors r=renatolabs,srosenberg |
|
bors cancel |
|
Canceled. |
|
bors r=renatolabs,srosenberg |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, DNS services for clusters would be registered in all cases. This can lead to some scenarios where
roachprodis unable to correctly determine the port of a service.When a cluster is created in a custom GCP project (non-default project) the
roachprodgarbage collector will destroy the records as it determines it has nothing to tie the resources to since it has no visibility of the custom project.As we currently do not test virtual clusters on AWS or Azure, these have also been excluded, because these providers do not specify using the Google Cloud DNS Provider yet. For that reason, there is no point in trying to register services.
Epic: None
Release Note: None