roachprod: use logger for printDetails
#120118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent update to PrintDetails redirected output to `os.Stdout`, it should preferably write to the logger, in order for it to end up in the correct log when used with `roachtest`. This change points it to `logger.Stdout` instead. See: cockroachdb#119763 Epic: None Release Note: None
herkolategan
requested review from
srosenberg,
renatolabs and
nameisbhaskar
and removed request for
a team
|
This change is |
nameisbhaskar
approved these changes
Mar 8, 2024
|
TFTR! bors r=nameisbhaskar,renatolabs |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent update to PrintDetails redirected output to
os.Stdout, it should preferably write to the logger, in order for it to end up in the correct log when used withroachtest. This change points it tologger.Stdoutinstead.See: #119763
Epic: None
Release Note: None