kvfeed: refactor and unit test copyFromSourceToDestUntilTableEvent #119959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
andyyang890
force-pushed
the
refactor_scan_boundary
branch
29 times, most recently
from
3833cf5 to
6d3f41f
Compare
andyyang890
force-pushed
the
refactor_scan_boundary
branch
5 times, most recently
from
ee05500 to
923da7c
Compare
andyyang890
changed the title
rharding6373
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @andyyang890 and @jayshrivastava)
pkg/ccl/changefeedccl/kvfeed/kv_feed_test.go line 553 at r1 (raw file):
It is used to populate mock schemafeed.TableEvent's.
nit: Is this sentence incomplete?
andyyang890
force-pushed
the
refactor_scan_boundary
branch
from
923da7c to
3834be8
Compare
This patch refactors `copyFromSourceToDestUntilTableEvent` and adds comments and a unit test. Release note: None
andyyang890
force-pushed
the
refactor_scan_boundary
branch
from
3834be8 to
1afd0d2
Compare
andyyang890
commented
Mar 7, 2024
There was a problem hiding this comment.
Reviewable status:
pkg/ccl/changefeedccl/kvfeed/kv_feed_test.go line 553 at r1 (raw file):
Previously, rharding6373 (Rachael Harding) wrote…
It is used to populate mock schemafeed.TableEvent's.
nit: Is this sentence incomplete?
I rephrased it, hopefully it's more clear now
|
TFTR! bors r=rharding6373 |
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors
copyFromSourceToDestUntilTableEventand addscomments and a unit test.
Epic: None
Release note: None