lint: make runnable under bazel test
#119589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rickystewart
force-pushed
the
lint-refactor
branch
5 times, most recently
from
996f852 to
7c0f4b6
Compare
rickystewart
changed the title
bazel testbazel test
rickystewart
force-pushed
the
lint-refactor
branch
3 times, most recently
from
dc6ea05 to
0a0d4cd
Compare
rickystewart
force-pushed
the
lint-refactor
branch
2 times, most recently
from
6bf2e1c to
a395a4f
Compare
rail
approved these changes
Mar 6, 2024
This test was never directly runnable under `bazel test`, and instead required using `bazel run` with the wrapper target `//build/bazelutil:lint` that set up some dependencies and some environment variables appropriately. Instead, we simply pass in those environment variables from the CI script or from `dev`, and add extra dependencies to the `lint_test` target (`crlfmt`, `optfmt`) so the test can use them. It's necessary to pass `GO_SDK` as a path to the Bazel-provided Go SDK and `COCKROACH_WORKSPACE` as the path to the checkout as this stuff will not be found in the sandbox. Epic: CRDB-8308 Release note: None
rickystewart
force-pushed
the
lint-refactor
branch
from
a395a4f to
dc26091
Compare
|
bors r=rail |
|
Build succeeded: |
Closed
rickystewart
added a commit
to rickystewart/cockroach
that referenced
this pull request
Mar 7, 2024
Regressed by cockroachdb#119589 Closes cockroachdb#120033 Epic: none Release note: None
herkolategan
added a commit
to herkolategan/cockroach
that referenced
this pull request
Mar 20, 2024
A change was recently added to a package `init` that causes a failure when listing the benchmarks for that package. These packages should be excluded from any interaction, to avoid complete execution failure. This is slightly different from the other `exclude` flag that is meant to not execute specific benchmarks within a given package. See: cockroachdb#119589 Epic: None Release Note: None
herkolategan
added a commit
to herkolategan/cockroach
that referenced
this pull request
Mar 21, 2024
Recently, `pkg/testutils/lint/lint_test.go` (cockroachdb#119589) added logic to `init`, that requires a `GO_SDK` env var that causes a failure when listing the benchmarks for that package, since on the target microbenchmark env there is no such env var specified. It's possible to add the env var to avoid failure. But in the future more logic that could probe the env var further could still cause a failure as go will not be installed on these machines. These packages should be excluded from any interaction, to avoid complete execution failure. This is slightly different from the other `exclude` flag that is meant to not execute specific benchmarks within a given package. See: cockroachdb#119589 Epic: None Release Note: None
craig bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
120752: roachprod-microbench,build: ignore packages r=renatolabs,srosenberg a=herkolategan Recently, `pkg/testutils/lint/lint_test.go` (#119589) added logic to `init`, that requires a `GO_SDK` env var that causes a failure when listing the benchmarks for that package, since on the target microbenchmark env there is no such env var specified. It's possible to add the env var to avoid failure. But in the future more logic that could probe the env var further could still cause a failure as go will not be installed on these machines. These packages should be excluded from any interaction, to avoid complete execution failure. This is slightly different from the other `exclude` flag that is meant to not execute specific benchmarks within a given package. See: #119589 Epic: None Release Note: None Co-authored-by: Herko Lategan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was never directly runnable under
bazel test, and insteadrequired using
bazel runwith the wrapper target//build/bazelutil:lintthat set up some dependencies and someenvironment variables appropriately. Instead, we simply pass in those
environment variables from the CI script or from
dev, and add extradependencies to the
lint_testtarget (crlfmt,optfmt) so the testcan use them.
It's necessary to pass
GO_SDKas a path to the Bazel-provided Go SDKand
COCKROACH_WORKSPACEas the path to the checkout as this stuff willnot be found in the sandbox.
Epic: CRDB-8308
Release note: None