sql: fix benchmark regressions #117807
Merged
sql: fix benchmark regressions #117807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes several benchmarks that incorrectly included cluster shutdown as part of the benchmark timing. This caused major regressions. See cockroachdb#117542 for more details. Release note: None
|
This change is |
rafiss
approved these changes
Jan 16, 2024
mgartner
commented
Jan 16, 2024
| @@ -3896,6 +3896,8 @@ func benchUserUpload(b *testing.B, uploadBaseURI string) { | |||
| `IMPORT INTO t CSV DATA ('%s%s')`, | |||
| uploadBaseURI, testFileBase, | |||
| )) | |||
|
|
|||
| b.StopTimer() | |||
There was a problem hiding this comment.
I'm skeptical of this benchmark. On my M1 Mac it now takes 0.12ns/op. But it looks like it was similarly fast before. The benchmark comparison sheet recorded it at 0.49ns/op before the regression.
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes several benchmarks that incorrectly included cluster
shutdown as part of the benchmark timing. This caused major regressions.
See #117542 for more details.
Epic: None
Release note: None