-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: kv: include locking strength and durability in Get/Scan/RevScan SafeFormat #116355
Conversation
ad7526a
to
aa1af2f
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @lyang24 and @nvanbenschoten)
The changes only come into affect when tracing a query.
Risks to backporting: a bug in this code might cause a traced query to fail.
23.2 will have major changes to row locking, and this change increases our observability of that row locking. I think there's a good chance we will need it during a support escalation. |
Reminder: it has been 3 weeks please merge or close your backport! |
…ormat The goal of this pr is improving observability. We are adding lock strength and lock durability with Get/Scan/RevScan request if the request is locking. This is implemented by introducing an optional extension interface to Request Interface called SafeFormatterRequest. We are also refactoring inside BatchRequest.SafeFormat with the added interface. Please note the subtle changed introduced here: if the EndKey is not present we print only Key with square brackets, and this applies to all the request types. Fixes: #114475 Release note: None.
This commit implements redact.SafeValue for PushTxnType with the goal of displaying the PushTxnType on PushTxnRequest with the redacted format. Fixes: #114475 Release note: None.
aa1af2f
to
7e830da
Compare
Rebased on release-23.2. I'll merge once tests are green. |
Failure is unrelated flake #116037. Merging. |
Backport 2/2 commits from #114481 on behalf of @lyang24.
/cc @cockroachdb/release
kv: include locking strength and durability in Get/Scan/RevScan SafeFormat
The goal of this pr is improving observability. We are adding lock strength
and lock durability with Get/Scan/RevScan request if the request is locking.
This is implemented by introducing an optional extension interface to Request
Interface called SafeFormatterRequest. We are also refactoring inside
BatchRequest.SafeFormat with the added interface. Please note the subtle
changed introduced here: if the EndKey is not present we print only Key with
square brackets, and this applies to all the request types.
Fixes: #114475
Release note: None.
Release justification: low-risk improvement to observability needed for read committed isolation.