Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clusterversion: fix formatting of versions comment #111369

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

RaduBerinde
Copy link
Member

Some of the formatting in this big comment is getting screwed up by
gofmt. This change fixes it - the trick was to make sure the "sub
lists" are all indented by a tab so it's all treated like a big code
block.

Epic: none
Release note: None

Some of the formatting in this big comment is getting screwed up by
gofmt. This change fixes it - the trick was to make sure the "sub
lists" are all indented by a tab so it's all treated like a big code
block.

Epic: none
Release note: None
@RaduBerinde RaduBerinde requested a review from celiala September 27, 2023 19:22
@blathers-crl
Copy link

blathers-crl bot commented Sep 27, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@celiala celiala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! LGTM

@RaduBerinde
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Sep 27, 2023

Build succeeded:

@craig craig bot merged commit f085187 into cockroachdb:master Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants