ccl/multiregionccl: unskip test multi region dd parent test #110063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Update the cluster setting statement to correctly surround the value duration in quotations.`5m` to `'5m'`. This was fixed in backports to release-23.1 (cockroachdb#110052) and release-22.2 (cockroachdb#110053). However, this was not caught on master due to `TestMultiRegionDataDriven` being skipped. Informs: cockroachdb#98020 Release note: None
kvoli
force-pushed
the
230905.unskip-multi-region-dd
branch
from
b8e8e8d to
bb1cb90
Compare
`TestMultiRegionDataDriven` was skipped in cockroachdb#108107 due to finish (tracing span) being called twice in raft reproposals cockroachdb#107521, which cockroachdb#108775 fixed. Unskip the top level `TestMultiRegionDataDriven` test. Note `/secondary_region` is still skipped due to a known allocator bug. Informs: cockroachdb#98020 Epic: none Release note: None
kvoli
force-pushed
the
230905.unskip-multi-region-dd
branch
from
bb1cb90 to
16cf27d
Compare
rafiss
approved these changes
Sep 6, 2023
|
TYFTR bors r=rafiss |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestMultiRegionDataDrivenwas skipped in #108107 due to finish(tracing span) being called twice in raft reproposals #107521, which
#108775 fixed.
Unskip the top level
TestMultiRegionDataDriventest. Note/secondary_regionis still skipped due to a known allocator bug.Informs: #98020
Epic: none
Release note: None