spanconfig: pass SpanConfig by pointer #109781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
andrewbaptist
force-pushed
the
2023-08-23-change-span-to-ptr
branch
9 times, most recently
from
3e65e4b to
c4dfe1e
Compare
andrewbaptist
force-pushed
the
2023-08-23-change-span-to-ptr
branch
6 times, most recently
from
04e2aca to
6032c5d
Compare
andrewbaptist
force-pushed
the
2023-08-23-change-span-to-ptr
branch
13 times, most recently
from
fa77aa4 to
fd36c6d
Compare
andrewbaptist
changed the title
andrewbaptist
force-pushed
the
2023-08-23-change-span-to-ptr
branch
2 times, most recently
from
2f400b9 to
2eef918
Compare
andrewbaptist
requested review from
adityamaru,
herkolategan and
srosenberg
and removed request for
a team
arulajmani
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Last 2 commits
Can we merge just the last 2 commits separately, so that this PR isn't blocked on the first commit?
Reviewed 25 of 25 files at r1, 3 of 3 files at r2, 24 of 24 files at r3, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @adityamaru, @herkolategan, and @srosenberg)
Epic: none Release note: None
andrewbaptist
force-pushed
the
2023-08-23-change-span-to-ptr
branch
from
2eef918 to
a75d38f
Compare
SpanConfig can be a large object and it is more efficient to pass by pointer now that it goes through multiple layers of code. Epic: none Release note: None
andrewbaptist
force-pushed
the
2023-08-23-change-span-to-ptr
branch
from
a75d38f to
3cbfa22
Compare
|
bors r=arulajmani |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Only the last 2 commits are only in this PR.
SpanConfig can be a large object and it is more efficient to pass by
pointer now that it goes through multiple layers of code.
Epic: none
Release note: None