Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: kvcoord: disable fatal assertion on transaction commit sanity check #107652

Merged
merged 1 commit into from
Jul 26, 2023
Merged

release-23.1: kvcoord: disable fatal assertion on transaction commit sanity check #107652

merged 1 commit into from
Jul 26, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jul 26, 2023 •
edited by AlexTalks
Loading

Backport 1/1 commits from #107596 on behalf of @AlexTalks.

/cc @cockroachdb/release

As #103817 is now a known issue for which a root cause has been identified, the sanity check assertion in place here is disabled, with errors occuring due to the known bug properly linking to the issue ticket. While the transaction coordinator still performs sanity checks to ensure that operations cannot continue on an already-committed transaction, it will no longer log the error with severity FATAL, resulting in node crash, and will instead simply return the error.

Part of: #103817

Release note: None

Release justification: Extraordinary fix to mitigate effects of #103817.

@AlexTalks
kvcoord: disable fatal assertion on transaction commit sanity check
e53f977 
As #103817 is now a known issue for which a root cause has been
identified, the sanity check assertion in place here is disabled, with
errors occuring due to the known bug properly linking to the issue
ticket. While the transaction coordinator still performs sanity checks
to ensure that operations cannot continue on an already-committed
transaction, it will no longer log the error with severity `FATAL`,
resulting in node crash, and will instead simply return the error.

Part of: #103817

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner July 26, 2023 18:19
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jul 26, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-107596 branch from d3db2e8 to f53f13d Compare July 26, 2023 18:19
@blathers-crl
Copy link
Author

blathers-crl bot commented Jul 26, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-107596 branch from e831cea to e53f977 Compare July 26, 2023 18:19
@blathers-crl blathers-crl bot requested review from nvanbenschoten and tbg July 26, 2023 18:19
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@AlexTalks AlexTalks requested a review from shralex July 26, 2023 18:23
@AlexTalks AlexTalks merged commit 4fa160b into release-23.1 Jul 26, 2023
@AlexTalks AlexTalks deleted the blathers/backport-release-23.1-107596 branch July 26, 2023 19:48
@AlexTalks AlexTalks mentioned this pull request Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbg tbg tbg approved these changes

@nvanbenschoten nvanbenschoten Awaiting requested review from nvanbenschoten

@shralex shralex Awaiting requested review from shralex

Assignees

@AlexTalks AlexTalks

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @tbg @AlexTalks