Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: kvserver: fix and re-enable slow lease application logging #105532

Closed

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jun 26, 2023

Backport 1/1 commits from #105519 on behalf of @erikgrinaker.

/cc @cockroachdb/release


Resolves #97209.

Epic: none
Release note: None


Release justification:

@blathers-crl blathers-crl bot requested a review from a team June 26, 2023 11:54
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-105519 branch from bcbc49f to 4d38240 Compare June 26, 2023 11:54
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 26, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 26, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-105519 branch from e640081 to 0de16c1 Compare June 26, 2023 11:54
@blathers-crl blathers-crl bot requested review from erikgrinaker and tbg June 26, 2023 11:54
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 26, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker
Copy link
Contributor

Will let this sit for a bit, to make sure it doesn't result in a bunch of log spam.

@github-actions
Copy link

Reminder: it has been 3 weeks please merge or close your backport!

@erikgrinaker
Copy link
Contributor

Going to poke at some roachtests this week, will have a look at this.

@github-actions
Copy link

Reminder: it has been 3 weeks please merge or close your backport!

@yuzefovich
Copy link
Member

@erikgrinaker do we want to merge this?

@erikgrinaker
Copy link
Contributor

I think it's fine to leave this for 23.2.

@yuzefovich yuzefovich deleted the blathers/backport-release-23.1-105519 branch January 31, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. no-backport-pr-activity O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants