cmdccl: test utility for running a /dev/null c2c stream #104318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
lidorcarmel
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
I just gave it a quick read yesterday.. looks fancy, but do you think we need this tool? initially I wanted to add it and then thought that making it a roachtest that runs regularly is more useful (the tool may rot if not used much, which is very likely).
maybe we can add a unit test to run this against a test cluster? to avoid rotting? I can look at that later.
anyway.. no objections, and I might make this into a roachtest one day.
A small utility for reading a tenant replication stream and doing nothing with it. Useful for manual testing. Epic: none Release note: None Co-authored-by: Steven Danna <[email protected]>
stevendanna
force-pushed
the
lidor/c2devnull
branch
from
b7bbf1a to
2cdae9f
Compare
|
bors r=lidorcarmel |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small utility for reading a tenant replication stream and doing nothing with it. Useful for manual testing.
Epic: none
Release note: None