release-22.2: kv: consider ErrReplicaNotFound and ErrReplicaCannotHoldLease to be retryable #100957
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #98116.
Fixes #101048.
Fixes #104183.
/cc @cockroachdb/release
Fixes #96746.
Fixes #100379.
This commit considers ErrReplicaNotFound and ErrReplicaCannotHoldLease to be retryable replication change errors when thrown by lease transfer requests. In doing so, these errors will be retried by the retry loop in
Replica.executeAdminCommandWithDescriptor
.This avoids spurious errors when a split gets blocked behind a lateral replica move like we see in the following situation:
replication change that added the voter_incoming to the range
4(b). lease transfer request delayed and delivered after voter_incoming has
been transferred the lease, added to the range, then removed from the
range.
In either case, retrying the AdminSplit operation on these errors will ensure that it eventually succeeds.
Release note (bug fix): Fixed a rare race that could allow large RESTOREs to fail with a
unable to find store
error.Release justification: avoids errors during splits, which can be seen during IMPORT and RESTORE.