-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: tenantcapabilities: restructure interfaces #100272
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is mostly just a refactoring of what we have. The previous iteration had some unfortunate coupling between the protobufs and the top-level package. Having the protobuf generated code not be a leaf hurts. Another pain point was the lack of strong typing when interacting with capabilities. Given this is go, somewhere there's a need to do some type assertion when dealing sets of variant instance types. The biggest change is that the `TenantCapabilities` concept is no longer wrapped in an interface implemented by the protobuf. Instead, the `Capability` implementations now live inside the `tenantcapabilities` package, and can be looked up with `FromName` and `FromID`, without any access to concrete capabilities. These capabilies then know how to look up values in a strongly typed way from the concrete capabilities. Epic: none Release note: None
7e72aae
to
6bf6807
Compare
b3a7a1f
to
0a3dccb
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
arulajmani
approved these changes
Mar 31, 2023
Will add #100294 before merging |
#100294 is merged |
The test should fail if we ever add a new type of capability and use it in the data driven test but don't update the test to handle it. Epic: none Follow-up from #100217 (review) Release note: None
I merged #100294 into this manually and will merge this PR once CI is green. |
stevendanna
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #100217 on behalf of @ajwerner.
/cc @cockroachdb/release
This commit is mostly just a refactoring of what we have. The previous iteration had some unfortunate coupling between the protobufs and the top-level package. Having the protobuf generated code not be a leaf hurts.
Another pain point was the lack of strong typing when interacting with capabilities. Given this is go, somewhere there's a need to do some type assertion when dealing sets of variant instance types.
The biggest change is that the
TenantCapabilities
concept is no longer wrapped in an interface implemented by the protobuf. Instead, theCapability
implementations now live inside thetenantcapabilities
package, and can be looked up withFromName
andFromID
, without any access to concrete capabilities. These capabilies then know how to look up values in a strongly typed way from the concrete capabilities.Epic: none
Release note: None
Release justification: simplifies the code and ensures further backports are successful