tenantcapabilities: add capabilities for Admin operations #95138
Assignees
Labels
branch-master
Failures and bugs on the master branch.
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Comments
arulajmani
added
the
C-enhancement
|
Hi @ajstorm, please add branch-* labels to identify which branch(es) this release-blocker affects. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
exalate-issue-sync
bot
added
T-sql-foundations
exalate-issue-sync
bot
added
branch-master
exalate-issue-sync
bot
added
T-sql-foundations
craig bot
pushed a commit
that referenced
this issue
Mar 15, 2023
98517: multitenant: add AdminMerge capability r=knz a=ecwall Fixes #95138 AdminMerge is currently only called by the system tenant even though it is named similarly to other Admin* functions so it does not need its own capability for now. This changes its required capability from noCapCheckNeeded to onlySystemTenant to prevent secondary tenants from calling it. Release note: None 98580: rpc: bump threshold for latency jump reporting r=erikgrinaker a=tbg For months I've seen this misfire in nearly every single log line I've looked at, and I've had to grep it out in many L2 incidents. Maybe it works better when we suppress it for latencies <=50ms. Touches #96262. Fixes #98066. Epic: none Release note: None 98688: colexecbase: fix a recently introduced bug with identity cast r=yuzefovich a=yuzefovich This commit fixes a recently introduced bug that can occur when we're randomizing `coldata.BatchSize()` (which we do in tests). In particular, we capped a global singleton at one batch size value, but later we can change it to a higher value, which could lead to index out of bounds. This is now fixed by always using the max batch size. Fixes: #98660. Release note: None 98700: opt: fix hoist of ANY comparison with tuples r=mgartner a=mgartner #### opt: fix hoist of ANY comparison with tuples Prior to this commit, when hoisting Any expressions like `<left> = ANY (SELECT <right> ...)`, we constructed `(IsNot <left|right> Null)` expressions which are equivalent to `<left|right> IS DISTINCT FROM NULL`. As discovered in #46675, these expressions have different behavior than `<left> IS NOT NULL` when `<left>` is a tuple. As a result, the hoisting transformations could construct invalid plans that cause incorrect results. This commit fixes the issue by using `IsTupleNotNull` expressions when `<left>` and `<right> are tupleq. Fixes #98691 Release note (bug fix): A bug has been fixes that caused incorrect results of ANY comparisons of tuples. For example, an expression like `(x, y) = ANY (SELECT a, b FROM t WHERE ...)` could return `true` instead of the correct result of `NULL` when `x` and `y` were `NULL`, or `a` and `b` were `NULL`. This could only occur if the subquery was correlated, i.e., it references columns from the outer part of the query. This bug was present since the cost-based optimizer was introduced in version 2.1. Co-authored-by: Evan Wall <[email protected]> Co-authored-by: Tobias Grieger <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: Marcus Gartner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Once #95040 lands, we'll have the underlying infrastructure to maintain in-memory capability state and to check against it for batch requests issued by secondary tenants. However, as of now, the only capability that exists is for performing
AdminSplitoperations. We should expand the set of capabilities to include other operations, such asAdminTransferLease,AdminRelocateRangeetc.Jira issue: CRDB-23363
Epic: CRDB-23344
The text was updated successfully, but these errors were encountered: