Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

22.2 --redact-logs deprecation warning should be at the END of the debug zip output #91685

Closed
smcvey opened this issue Nov 10, 2022 · 1 comment
Closed

22.2 --redact-logs deprecation warning should be at the END of the debug zip output #91685

smcvey opened this issue Nov 10, 2022 · 1 comment
Assignees
@abarganier
Labels
A-observability-inf C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Comments

@smcvey
Copy link
Contributor

smcvey commented Nov 10, 2022 •
edited by exalate-issue-sync bot
Loading

Describe the problem

When running debug zip debug.zip --redact-logs in 22.2, the deprecation warning happens at the TOP of the debug output:

[vagrant@node-1 ~]$ cockroach debug zip --redact-logs debug.zip
Flag --redact-logs has been deprecated, use --redact instead
[cluster] WARNING: The --redact-logs flag has been deprecated in favor of the --redact flag. Interpreting as --redact and continuing.
[cluster] establishing RPC connection to localhost:26257...
[cluster] establishing RPC connection to localhost:26257: done
[cluster] retrieving the node status to get the SQL address...
[cluster] retrieving the node status to get the SQL address: done
[cluster] using SQL address: 172.28.128.21:26257...
...

The issue with this is that an operator who is used to using --redact-logs will not notice the warning at the top because it's quickly spammed out by the rest. It needs to be at the bottom with a huge **** banner **** around it.

Jira issue: CRDB-21385

Epic CRDB-12732
@smcvey smcvey added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Nov 10, 2022
@abarganier abarganier self-assigned this Nov 11, 2022
@abarganier abarganier mentioned this issue Nov 11, 2022
Merged
@abarganier
Copy link
Contributor

abarganier commented Nov 11, 2022 •
edited
Loading

The above PR moves the message to the very bottom of the debug zip output (last line logged), and updates it to:

[cluster] WARNING: The --redact-logs flag has been deprecated in favor of the --redact flag. The flag has been interpreted as --redact instead.

@abarganier abarganier added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. and removed C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. labels Nov 11, 2022
craig bot pushed a commit that referenced this issue Nov 14, 2022
@andreimatei @abarganier @knz
Merge #91635 #91754 #91830
a00fbe9 
91635: jobs: add a comment about the Resumer contract r=andreimatei a=andreimatei

Release note: None
Epic: None

91754: zip: move `--redact-logs` deprecation warning to end of zip output r=dhartunian a=abarganier

This patch simply moves the deprecation notice for the `--redact-logs` flag to the bottom of the debug zip output. Previously, the message was logged at the beginning of the output, which was quickly drowned out by the rest of the output indicating the debug zip progress.

Release note: none

Addresses #91685

Epic: CRDB-12732

91830: sql/importer: skip a flaky test r=rafiss a=knz

Informs #91828.
Informs  #91845.
Informs #91850.

Co-authored-by: Andrei Matei <[email protected]>
Co-authored-by: Alex Barganier <[email protected]>
Co-authored-by: Raphael 'kena' Poss <[email protected]>
@blathers-crl blathers-crl bot mentioned this issue Nov 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abarganier abarganier

Labels
A-observability-inf C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thtruo @abarganier @smcvey