ui: update transaction duration filter label on the Transactions Overview page #91206
Assignees
Labels
A-sql-observability
Related to observability of the SQL layer
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Comments
ericharmeling
added
C-bug
craig bot
pushed a commit
that referenced
this issue
Nov 4, 2022
89584: cloud: add read and write metrics r=adityamaru a=adityamaru This change adds cloud.read_bytes and cloud.write_bytes metrics. These are updated on all read/write operations to external storage endpoints. These metrics while shared by all external storage interactions will provide an immediate signal into whether we're seeing an abnormal rate of reads and writes errors during support investigations. Fixes: #89242 Release note: None 91205: descidgen: use system.descriptor_id_seq for all tenants r=postamar a=postamar Previously, the system tenant used a legacy non-SQL key in the meta range to generate descriptor IDs, while non-system tenants used the system.descriptor_id_seq sequence. This commit introduces a cluster upgrade step which creates this sequence in the the system tenant's system database and migrates the legacy counter value to it. While this migration is underway, the descriptor ID generator is not available. This upgrade consists of a relatively brief transaction and descriptor ID generation is a relatively infrequent event, as a result the disruption is deemed tolerable. Fixes #80294. Release note (sql change): upgrading a cluster to a major release containing this patch will endow the system tenant's system database with a descriptor_id_seq sequence which will henceforth be used to generate new descriptor IDs, as is already the case for non-system tenants. 91225: rttanalysis: skip slow test case r=ajwerner a=rafiss see also #88885 Release note: None 91231: storage: remove legacy SST iterator r=nicktrav a=jbowens The legacy sstable iterator is no longer in use. Removing the legacy sstable iterator now also avoids updating it to accommodate the new Pebble internal iterator interface with lazy value fetching. Epic: None Release note: None 91245: sql: include all schemas into schema.sql in the bundle r=yuzefovich a=yuzefovich This commit makes it so that all schemas are added into the `schema.sql` file of the statement bundle using `SHOW CREATE ALL SCHEMAS;` statement (the only exception is the public schema that always exists in CRDB clusters). This will make it more likely that `debug statement-bundle recreate` succeeds on the bundles. Fixes: #91099. Epic: None Release note: None 91255: ui: fixes on sql activity filter r=maryliag a=maryliag This commit fixes the label of Transaction filter and add the proper color for the filter styles (previously was being loaded as a different color on the Sessions page because it was being inherit from another component) Fixes #91206 Transactions Before <img width="457" alt="Screen Shot 2022-11-03 at 7 07 13 PM" src="https://user-images.githubusercontent.com/1017486/199851829-b747102a-ac70-4720-97b5-7911b742345c.png"> Transactions After <img width="477" alt="Screen Shot 2022-11-03 at 6 55 14 PM" src="https://user-images.githubusercontent.com/1017486/199851704-71641bb6-8247-4d92-8f2d-3efd27846594.png"> Sessions Before <img width="317" alt="Screen Shot 2022-11-03 at 6 36 51 PM" src="https://user-images.githubusercontent.com/1017486/199851596-313646b9-0188-48aa-9392-7dd7f3eded99.png"> Sessions After <img width="309" alt="Screen Shot 2022-11-03 at 6 55 06 PM" src="https://user-images.githubusercontent.com/1017486/199851671-02d4db08-4f2b-4ac3-95ff-e1d98e2d6ede.png"> Before/After of Statement page continues the same <img width="604" alt="Screen Shot 2022-11-03 at 6 55 28 PM" src="https://user-images.githubusercontent.com/1017486/199851734-06a8a131-3528-4d17-a856-9d39d67e7017.png"> Release note (ui change): Fix Transaction filter label on SQL Activity page. 91260: sql: add crdb_internal.descriptor_with_post_deserialization_changes r=postamar a=postamar This builtin applies post-deserialization changes to descriptors. This is useful during descriptor surgery as well as, potentially, during cluster upgrade steps. Fixes #90269. Release note: None 91289: tracing: use timeutil for Now() and Since() r=yuzefovich a=yuzefovich Previously, for performance reasons (as well as a few others) we used `time.Now()` and `time.Since` in the tracing library. But the work in f782e45 alleviated those concerns, so we can now switch to using `timeutil` library in two places. ``` Tracer_StartSpanCtx/opts=none-24 508ns ± 0% 512ns ± 0% +0.80% (p=0.000 n=10+10) Tracer_StartSpanCtx/opts=real-24 510ns ± 1% 515ns ± 1% +0.96% (p=0.000 n=10+10) Tracer_StartSpanCtx/opts=real,logtag-24 539ns ± 1% 544ns ± 1% +0.90% (p=0.000 n=10+10) Tracer_StartSpanCtx/opts=real,autoparent-24 480ns ± 0% 486ns ± 1% +1.26% (p=0.000 n=10+10) Tracer_StartSpanCtx/opts=real,manualparent-24 523ns ± 1% 527ns ± 1% +0.91% (p=0.004 n=10+10) Tracer_StartSpanCtx/opts=real,autoparent,withEventListener-24 755ns ± 0% 765ns ± 0% +1.40% (p=0.000 n=10+10) Tracer_StartSpanCtx/opts=real,manualparent,withEventListener-24 547ns ± 1% 552ns ± 1% +0.89% (p=0.000 n=10+10) Span_GetRecording/root-only-24 7.36ns ± 0% 6.75ns ± 0% -8.26% (p=0.000 n=10+10) Span_GetRecording/child-only-24 7.36ns ± 0% 6.75ns ± 0% -8.30% (p=0.000 n=10+10) Span_GetRecording/root-child-24 7.36ns ± 0% 6.74ns ± 0% -8.32% (p=0.000 n=10+10) RecordingWithStructuredEvent/with-event-listener-24 3.47µs ± 1% 3.47µs ± 1% ~ (p=0.541 n=10+10) RecordingWithStructuredEvent/without-event-listener-24 3.31µs ± 0% 3.32µs ± 1% ~ (p=0.271 n=10+10) SpanCreation/detached-child=false-24 1.07µs ± 1% 1.07µs ± 1% ~ (p=0.955 n=10+10) SpanCreation/detached-child=true-24 1.84µs ± 1% 1.82µs ± 1% -1.30% (p=0.000 n=10+10) ``` And no changes in allocations. Epic: None Release note: None 91292: sql,delegate: cleanup from PR to improve performance of vtables with many databases r=ajwerner a=ajwerner This is fallout from #91054 (review). See individual commits. Epic: None Release note: None Co-authored-by: adityamaru <[email protected]> Co-authored-by: Marius Posta <[email protected]> Co-authored-by: Rafi Shamim <[email protected]> Co-authored-by: Jackson Owens <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: maryliag <[email protected]> Co-authored-by: Andrew Werner <[email protected]>
blathers-crl bot
pushed a commit
that referenced
this issue
Nov 4, 2022
This commit fixes the label of Transaction filter and add the proper color for the filter styles (previously was being loaded as a different color on the Sessions page because it was being inherit from another component) Fixes #91206 Release note (ui change): Fix Transaction filter label on SQL Activity page.
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Nov 4, 2022
This commit fixes the label of Transaction filter and add the proper color for the filter styles (previously was being loaded as a different color on the Sessions page because it was being inherit from another component) Fixes cockroachdb#91206 Release note (ui change): Fix Transaction filter label on SQL Activity page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The transaction duration filter on the Transactions Overview page reads “Statement fingerprint runs longer than”:
This should read “Transaction fingerprint execution runs longer than”, or something to that effect.
Jira issue: CRDB-21152
The text was updated successfully, but these errors were encountered: