SQL panic has occurred while executing ALTER DEFAULT PRIVILEGES

[sravotto]

A SQL panic has occurred while executing ALTER DEFAULT PRIVILEGES.

Version Info: CCL v22.1.8 @ 2022/09/29 14:21:51 (go1.17.11)

Steps to reproduce:

CREATE ROLE foo; 
GRANT CONNECT ON DATABASE defaultdb TO foo;
USE system;            
GRANT foo TO root;         
ALTER DEFAULT PRIVILEGES FOR ROLE foo REVOKE ALL ON TABLES FROM foo;

Stack trace:

* ERROR: a SQL panic has occurred while executing the following statement:
* ALTER DEFAULT PRIVILEGES FOR ROLE foo REVOKE ALL ON TABLES  FROM foo
*
*
* ERROR: a panic has occurred!
* runtime error: invalid memory address or nil pointer dereference
* (1) attached stack trace
*   -- stack trace:
*   | github.com/cockroachdb/cockroach/pkg/sql.(*Server).ServeConn.func1
*   | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:761
*   | [...repeated from below...]
* Wraps: (2) while executing: ALTER DEFAULT PRIVILEGES FOR ROLE _ REVOKE ALL ON TABLES  FROM _
* Wraps: (3) attached stack trace
*   -- stack trace:
*   | github.com/cockroachdb/cockroach/pkg/sql.(*Server).ServeConn.func1
*   | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:761
*   | runtime.gopanic
*   | 	GOROOT/src/runtime/panic.go:1038
*   | github.com/cockroachdb/cockroach/pkg/sql/colexecerror.CatchVectorizedRuntimeError.func1
*   | 	github.com/cockroachdb/cockroach/pkg/sql/colexecerror/error.go:58
*   | runtime.gopanic
*   | 	GOROOT/src/runtime/panic.go:1038
*   | runtime.panicmem
*   | 	GOROOT/src/runtime/panic.go:221
*   | runtime.sigpanic
*   | 	GOROOT/src/runtime/signal_unix.go:735
*   | github.com/cockroachdb/cockroach/pkg/sql/catalog/descs.(*uncommittedDescriptors).add
*   | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/descs/uncommitted_descriptors.go:168
*   | github.com/cockroachdb/cockroach/pkg/sql/catalog/descs.(*uncommittedDescriptors).checkIn
*   | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/descs/uncommitted_descriptors.go:204
*   | github.com/cockroachdb/cockroach/pkg/sql/catalog/descs.(*Collection).AddUncommittedDescriptor
*   | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/descs/collection.go:212
*   | github.com/cockroachdb/cockroach/pkg/sql/catalog/descs.(*Collection).WriteDescToBatch
*   | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/descs/collection.go:235
*   | github.com/cockroachdb/cockroach/pkg/sql.(*planner).writeDatabaseChangeToBatch
*   | 	github.com/cockroachdb/cockroach/pkg/sql/database.go:90
*   | github.com/cockroachdb/cockroach/pkg/sql.(*planner).writeNonDropDatabaseChange
*   | 	github.com/cockroachdb/cockroach/pkg/sql/database.go:78
*   | github.com/cockroachdb/cockroach/pkg/sql.(*alterDefaultPrivilegesNode).alterDefaultPrivilegesForDatabase
*   | 	github.com/cockroachdb/cockroach/pkg/sql/alter_default_privileges.go:367
*   | github.com/cockroachdb/cockroach/pkg/sql.(*alterDefaultPrivilegesNode).startExec
*   | 	github.com/cockroachdb/cockroach/pkg/sql/alter_default_privileges.go:166
*   | github.com/cockroachdb/cockroach/pkg/sql.startExec.func2
*   | 	github.com/cockroachdb/cockroach/pkg/sql/plan.go:516
*   | github.com/cockroachdb/cockroach/pkg/sql.(*planVisitor).visitInternal.func1
*   | 	github.com/cockroachdb/cockroach/pkg/sql/walk.go:112
*   | github.com/cockroachdb/cockroach/pkg/sql.(*planVisitor).visitInternal
*   | 	github.com/cockroachdb/cockroach/pkg/sql/walk.go:297
*   | github.com/cockroachdb/cockroach/pkg/sql.(*planVisitor).visit
*   | 	github.com/cockroachdb/cockroach/pkg/sql/walk.go:79
*   | github.com/cockroachdb/cockroach/pkg/sql.walkPlan
*   | 	github.com/cockroachdb/cockroach/pkg/sql/walk.go:43
*   | github.com/cockroachdb/cockroach/pkg/sql.startExec
*   | 	github.com/cockroachdb/cockroach/pkg/sql/plan.go:519
*   | github.com/cockroachdb/cockroach/pkg/sql.(*planNodeToRowSource).Start
*   | 	github.com/cockroachdb/cockroach/pkg/sql/plan_node_to_row_source.go:146
*   | github.com/cockroachdb/cockroach/pkg/sql/colflow.(*FlowCoordinator).Start.func1
*   | 	github.com/cockroachdb/cockroach/pkg/sql/colflow/flow_coordinator.go:120
*   | github.com/cockroachdb/cockroach/pkg/sql/colexecerror.CatchVectorizedRuntimeError
*   | 	github.com/cockroachdb/cockroach/pkg/sql/colexecerror/error.go:92
*   | github.com/cockroachdb/cockroach/pkg/sql/colflow.(*FlowCoordinator).Start
*   | 	github.com/cockroachdb/cockroach/pkg/sql/colflow/flow_coordinator.go:119
*   | github.com/cockroachdb/cockroach/pkg/sql/execinfra.(*ProcessorBaseNoHelper).Run
*   | 	github.com/cockroachdb/cockroach/pkg/sql/execinfra/processorsbase.go:753
*   | github.com/cockroachdb/cockroach/pkg/sql/flowinfra.(*FlowBase).Run
*   | 	github.com/cockroachdb/cockroach/pkg/sql/flowinfra/flow.go:469
*   | github.com/cockroachdb/cockroach/pkg/sql/colflow.(*vectorizedFlow).Run
*   | 	github.com/cockroachdb/cockroach/pkg/sql/colflow/vectorized_flow.go:303
*   | github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).Run
*   | 	github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:597
*   | github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).PlanAndRun
*   | 	github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:1445
*   | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execWithDistSQLEngine
*   | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1506
*   | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).dispatchToExecutionEngine
*   | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1163
*   | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmtInOpenState
*   | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:699
* Wraps: (4) runtime error: invalid memory address or nil pointer dereference
* Error types: (1) *withstack.withStack (2) *safedetails.withSafeDetails (3) *withstack.withStack (4) runtime.errorString
*

Jira issue: CRDB-20423

[blathers-crl]

Hi @sravotto, please add a C-ategory label to your issue. Check out the label system docs.

While you're here, please consider adding an A- label to help keep our repository tidy.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[rafiss]

In v22.2, I get the error:

root@localhost:26257/system> ALTER DEFAULT PRIVILEGES FOR ROLE foo REVOKE ALL ON TABLES FROM foo;                                                           
ERROR: unexpected value: raw_bytes:"\304\036\346\327\003\0229\n\006system\020\001\032%\n\r\n\005admin\020\200\020\030\200\020\n\014\n\004root\020\200\020\030\200\020\022\004node\030\002\"\000(\001@\000J\000" timestamp:<wall_time:1668548990774990000 >

Also, i've confirmed that the problem only occurs when you USE the system database.