Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add button to drop index on index stats when there is a drop recommendation #86949

Closed
maryliag opened this issue Aug 26, 2022 · 0 comments · Fixed by #90070
Closed

add button to drop index on index stats when there is a drop recommendation #86949

maryliag opened this issue Aug 26, 2022 · 0 comments · Fixed by #90070
Assignees
@maryliag
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@maryliag
Copy link
Contributor

maryliag commented Aug 26, 2022 •
edited by exalate-issue-sync bot
Loading

We added a button to execute index recommendations on insights and statement details page. We should also add to the drop recommendation on database page

Jira issue: CRDB-19053

Epic CRDB-20388
@maryliag maryliag added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-observability labels Aug 26, 2022
@maryliag maryliag self-assigned this Oct 13, 2022
maryliag added a commit to maryliag/cockroach that referenced this issue Oct 17, 2022
@maryliag
ui: add apply recommendations to table details
810fff6 
On Table details page, we have a table with index
recommendations, which right now is focused on drop
unused indexes. This commit adds the button the apply
the recommendations, when there is one.

Fixes cockroachdb#86949

Release note (ui change): Add apply button on Table Details
page (db console only), when there is a recommendation to
drop an unused index.
@maryliag maryliag mentioned this issue Oct 17, 2022
Merged
craig bot pushed a commit that referenced this issue Oct 17, 2022
@michae2 @maryliag @irfansharif
Merge #90017 #90070 #90093
762c1b8 
90017: sql: remove unnecessary rowsorts from distsql_stats logic tests r=mgartner a=michae2

**sql: remove unnecessary rowsorts from distsql_stats logic tests**

In distsql_stats and distsql_automatic_stats logic tests we frequently
use queries like the following:

```sql
SELECT ...
FROM [SHOW STATISTICS FOR TABLE foo]
ORDER BY column_names, created DESC
```

These queries have guaranteed order, and do not need the rowsort option.

Epic: CRDB-20535

Release note: None

**sql: bump testlogic --rewrite delay for queries with retry to 2 sec**

This prevents some spurious rewrites in the distsql_automatic_stats
logic test.

Epic: CRDB-20535

Release note: None

90070: ui: add apply recommendations to table details r=maryliag a=maryliag

On Table details page, we have a table with index
recommendations, which right now is focused on drop unused indexes. This commit adds the button the apply the recommendations, when there is one.

Fixes #86949
<img width="1235" alt="Screen Shot 2022-10-17 at 12 49 05 PM" src="https://user-images.githubusercontent.com/1017486/196237146-72814f16-05c4-4bba-a716-f6ba875c7b65.png">

<img width="1281" alt="Screen Shot 2022-10-17 at 12 49 11 PM" src="https://user-images.githubusercontent.com/1017486/196237156-777470de-3fd8-41ea-951f-d053bf6337a1.png">



Release note (ui change): Add apply button on Table Details page (db console only), when there is a recommendation to drop an unused index.

90093: changefeed,kvcoord: populate AC headers for backfill work r=irfansharif a=irfansharif

This is an opportunistic change and something to backport to v22.2. In v22.2 we introduced a disabled-by-default elastic CPU limiter (#86638) to dynamically grant CPU time for background work like backups -- something hope to enable-by-default in CC and under observation for select 22.2 clusters. Recently we found another use for this limiter -- rangefeed catchup scans (#89709). It's unclear yet whether we want that integration to make it back to v22.2 but this commit leaves that option open by populating the right AC headers we'd need for the integration. Populating these AC headers is safe -- the Rangefeed RPC is not hooked into AC yet, so these headers are not looked at. For the initial scan requests we're only setting a lower priority bit, something 22.1 nodes already know to handle (they do so for all batch requests).

Release note: None
Release justification: Low-risk change that opens the door to a future backport in a non-.0 release to address cases where rangefeed catchup scans affect foreground latencies.

Co-authored-by: Michael Erickson <[email protected]>
Co-authored-by: maryliag <[email protected]>
Co-authored-by: irfan sharif <[email protected]>
@craig craig bot closed this as completed in eb64879 Oct 17, 2022
maryliag added a commit to maryliag/cockroach that referenced this issue Dec 2, 2022
@maryliag
ui: add apply recommendations to table details
371c955 
On Table details page, we have a table with index
recommendations, which right now is focused on drop
unused indexes. This commit adds the button the apply
the recommendations, when there is one.

Fixes cockroachdb#86949

Release note (ui change): Add apply button on Table Details
page (db console only), when there is a recommendation to
drop an unused index.
@maryliag maryliag mentioned this issue Dec 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryliag maryliag

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: add apply recommendations to table details maryliag/cockroach
1 participant
@maryliag