Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: for bazel build configs, reported data races don't show up in test.xml file #74105

Closed
rickystewart opened this issue Dec 20, 2021 · 0 comments · Fixed by #87130
Closed

ci: for bazel build configs, reported data races don't show up in test.xml file #74105

rickystewart opened this issue Dec 20, 2021 · 0 comments · Fixed by #87130
Labels
A-ci Continuous Integration C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf

Comments

@rickystewart
Copy link
Collaborator

rickystewart commented Dec 20, 2021 •
edited by exalate-issue-sync bot
Loading

Example build

In the build logs, you can see a data race was detected. The dropdown test output for the failed tests doesn't include this, however. This is because the test.xml file for the test doesn't contain the data race detection output.

Epic CRDB-8349
Jira issue: CRDB-11921
@rickystewart rickystewart added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf A-ci Continuous Integration labels Dec 20, 2021
@rickystewart rickystewart changed the title ci: reported data races don't show up in test.xml file ci: for bazel build configs, reported data races don't show up in test.xml file Dec 20, 2021
@rickystewart rickystewart mentioned this issue Feb 14, 2022
Closed
@rickystewart rickystewart mentioned this issue Apr 29, 2022
Closed
@rickystewart rickystewart mentioned this issue Aug 30, 2022
Merged
craig bot pushed a commit that referenced this issue Aug 30, 2022
@andreimatei @rickystewart
Merge #87054 #87130
d07bea8 
87054: sql: fix exporting of events to Obs Service r=andreimatei a=andreimatei

In #86174, exporting of events to the Obs Service was doubly-decoupled
from the SQL statement causing the event: it ran in an async task inside
another async task. The inner task was given a context canceled when the
outer task finished - thus introducing a race causing the event to not
be passed along. This was caught by TestEventIngestionIntegration
flakiness.
The second task was unnecessary. Its purpose was to shield the caller
from slow communication with the Obs Service, but the client library
being used already does that (it's non-blocking).

Release note: None
Release justification: bug fix, test flakiness

87130: bazel: set `GORACE` variable appropriately when testing w/ `race` r=rail,srosenberg a=rickystewart

By default the `race` data is output to `stderr`, which means it ends up
in the `test.log` file but NOT the `test.xml` file. Changing it to
`stdout` means that this instead ends up `test.xml` as well as
`test.log` and any output JSON files.

Closes #74105.

Release justification: Non-production code changes
Release note: None

Co-authored-by: Andrei Matei <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>
@craig craig bot closed this as completed in a0051e5 Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ci Continuous Integration C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bazel: set GORACE variable appropriately when testing w/ race rickystewart/cockroach
1 participant
@rickystewart