Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: Import prometheus PromQL parser as external library. #69796

Closed
rimadeodhar opened this issue Sep 2, 2021 · 0 comments · Fixed by #70325
Closed

metrics: Import prometheus PromQL parser as external library. #69796

rimadeodhar opened this issue Sep 2, 2021 · 0 comments · Fixed by #70325
Assignees
@rimadeodhar
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@rimadeodhar
Copy link
Collaborator

rimadeodhar commented Sep 2, 2021 •
edited
Loading

The PromQL parser library will be used to verify the correctness of the alerting and aggregation rule expressions and needs to be imported into the vendors submodule.

Epic: CRDB 2573
@rimadeodhar rimadeodhar added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Sep 2, 2021
@rimadeodhar rimadeodhar self-assigned this Sep 2, 2021
rimadeodhar added a commit to rimadeodhar/cockroach that referenced this issue Sep 9, 2021
@rimadeodhar
vendor: Add dependency on prometheus/prometheus
de4c088 
This PR adds an external dependency on prometheus. We need
the promql library in order to enforce validity of promql
expressions which will be contained in upcoming alerting
and aggregation rules. These rule implementations are
upcoming as a part of the new metrics upgrade.

Resolves cockroachdb#69796

Release note: None
This was referenced Sep 9, 2021
Closed
Merged
@craig craig bot closed this as completed in bfdcfa0 Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rimadeodhar rimadeodhar

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
1 participant
@rimadeodhar