Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admission control: integration for sql=>sql response processing, DistSQL leaf and root start-work #65948

Closed
sumeerbhola opened this issue Jun 1, 2021 · 2 comments
Closed

admission control: integration for sql=>sql response processing, DistSQL leaf and root start-work #65948

sumeerbhola opened this issue Jun 1, 2021 · 2 comments
Labels
A-admission-control C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale

Comments

@sumeerbhola
Copy link
Collaborator

sumeerbhola commented Jun 1, 2021 •
edited by cockroach-jira-scripts
Loading

The admission control package has the following WorkKinds that are not currently integrated with the places where the work happens: SQLSQLResponseWork, SQLStatementLeafStartWork, SQLStatementRootStartWork.

This integration is necessary for successfully using node-level admission control in a multi-node cluster. As part of this integration we need to also create and run multi-node roachtests that try to overload a specific node in the cluster or all nodes.

Jira issue: CRDB-7809
@sumeerbhola sumeerbhola added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-admission-control labels Jun 1, 2021
@sumeerbhola sumeerbhola mentioned this issue Jul 13, 2021
Merged
sumeerbhola added a commit to sumeerbhola/cockroach that referenced this issue Jul 13, 2021
@sumeerbhola
sql,server: add admission control for DistSQL responses
0ff14f2 
The admission.WorkQueue is plumbed through via execinfra.ServerCfg
to colrpc.Inbox and flowinfra.processProducerMessage, and the
AdmissionInfo is initialized using FlowCtx.Txn when possible.

The admission control point for KV=>SQL response processing
is tweaked to move it after the memory accounting for the
response bytes.

Informs cockroachdb#65948

Release note (ops change): DistSQL response admission control
can be enabled using admission.sql_sql_response.enabled.
sumeerbhola added a commit to sumeerbhola/cockroach that referenced this issue Jul 14, 2021
@sumeerbhola
sql,server: add admission control for DistSQL responses
435d127 
The admission.WorkQueue is plumbed through via execinfra.ServerCfg
to colrpc.Inbox and flowinfra.processProducerMessage, and the
AdmissionInfo is initialized using FlowCtx.Txn when possible.

The admission control point for KV=>SQL response processing
is tweaked to move it after the memory accounting for the
response bytes.

Informs cockroachdb#65948

Release note (ops change): DistSQL response admission control
can be enabled using admission.sql_sql_response.enabled.
sumeerbhola added a commit to sumeerbhola/cockroach that referenced this issue Jul 14, 2021
@sumeerbhola
sql,server: add admission control for DistSQL responses
68beda6 
The admission.WorkQueue is plumbed through via execinfra.ServerCfg
to colrpc.Inbox and flowinfra.processProducerMessage, and the
AdmissionInfo is initialized using FlowCtx.Txn when possible.

The admission control point for KV=>SQL response processing
is tweaked to move it after the memory accounting for the
response bytes.

Informs cockroachdb#65948

Release note (ops change): DistSQL response admission control
can be enabled using admission.sql_sql_response.enabled.
craig bot pushed a commit that referenced this issue Jul 15, 2021
@sumeerbhola
Merge #67531
41a58d0 
67531: sql,server: add admission control for DistSQL responses r=sumeerbhola a=sumeerbhola

The admission.WorkQueue is plumbed through via execinfra.ServerCfg
to colrpc.Inbox and flowinfra.processProducerMessage, and the
AdmissionInfo is initialized using FlowCtx.Txn when possible.

The admission control point for KV=>SQL response processing
is tweaked to move it after the memory accounting for the
response bytes.

Informs #65948

Release note (ops change): DistSQL response admission control
can be enabled using admission.sql_sql_response.enabled.

Co-authored-by: sumeerbhola <[email protected]>
pawalt pushed a commit to pawalt/cockroach that referenced this issue Jul 22, 2021
@sumeerbhola @pawalt
sql,server: add admission control for DistSQL responses
6c595c3 
The admission.WorkQueue is plumbed through via execinfra.ServerCfg
to colrpc.Inbox and flowinfra.processProducerMessage, and the
AdmissionInfo is initialized using FlowCtx.Txn when possible.

The admission control point for KV=>SQL response processing
is tweaked to move it after the memory accounting for the
response bytes.

Informs cockroachdb#65948

Release note (ops change): DistSQL response admission control
can be enabled using admission.sql_sql_response.enabled.
@sumeerbhola
Copy link
Collaborator Author

SQLSQLResponseWork is done

@sumeerbhola sumeerbhola mentioned this issue Oct 26, 2021
Closed
@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-admission-control C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sumeerbhola