Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add support for the ALTER SCHEMA RENAME TO command #50880

Closed
rohany opened this issue Jul 1, 2020 · 0 comments · Fixed by #52349
Closed

sql: add support for the ALTER SCHEMA RENAME TO command #50880

rohany opened this issue Jul 1, 2020 · 0 comments · Fixed by #52349
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@rohany
Copy link
Contributor

rohany commented Jul 1, 2020

This command renames a schema.
@rohany rohany added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jul 1, 2020
@rohany rohany mentioned this issue Jul 1, 2020
Closed
12 tasks
@rohany rohany mentioned this issue Jul 30, 2020
Merged
rohany added a commit to rohany/cockroach that referenced this issue Aug 3, 2020
@rohany
sql: parse and recognize ALTER SCHEMA and DROP SCHEMA
1d34680 
Touches cockroachdb#50880.
Touches cockroachdb#50884.

This commit adds the boilerplate for adding the `ALTER SCHEMA` and `DROP
SCHEMA` statements.

Release note: None
craig bot pushed a commit that referenced this issue Aug 3, 2020
@rohany @RaduBerinde
Merge #52167 #52232
a11e783 
52167: sql: parse and recognize `ALTER SCHEMA` and `DROP SCHEMA` r=otan a=rohany

Touches #50880.
Touches #50884.

This commit adds the boilerplate for adding the `ALTER SCHEMA` and `DROP
SCHEMA` statements.

Release note: None

52232: sql: don't show grouping columns as aggregations in EXPLAIN r=RaduBerinde a=RaduBerinde

EXPLAIN shows grouping columns as aggregations. This was carried over
from the heuristic planner. Now the groupNode always produces all
grouping columns; we don't need to list them as aggregations.

Release note (sql change): EXPLAIN no longer shows grouping columns as
"aggregations" for the group operator.

Co-authored-by: Rohan Yadav <[email protected]>
Co-authored-by: Radu Berinde <[email protected]>
@rohany rohany mentioned this issue Aug 4, 2020
Merged
rohany added a commit to rohany/cockroach that referenced this issue Aug 6, 2020
@rohany
sql: implement ALTER SCHEMA RENAME TO
6d8a764 
Fixes cockroachdb#50880.

This commit implements the `ALTER SCHEMA RENAME TO` command. It reuses
the existing schema change infrastructure to handle a more general case
of an arbitrary descriptor that just needs names and existing leases
drained.

Release note (sql change): Implement the `ALTER SCHEMA RENAME TO`
command.
rohany added a commit to rohany/cockroach that referenced this issue Aug 10, 2020
@rohany
sql: implement ALTER SCHEMA RENAME TO
bcc2776 
Fixes cockroachdb#50880.

This commit implements the `ALTER SCHEMA RENAME TO` command. It reuses
the existing schema change infrastructure to handle a more general case
of an arbitrary descriptor that just needs names and existing leases
drained.

Release note (sql change): Implement the `ALTER SCHEMA RENAME TO`
command.
rohany added a commit to rohany/cockroach that referenced this issue Aug 12, 2020
@rohany
sql: implement ALTER SCHEMA RENAME TO
bd00154 
Fixes cockroachdb#50880.

This commit implements the `ALTER SCHEMA RENAME TO` command. It reuses
the existing schema change infrastructure to handle a more general case
of an arbitrary descriptor that just needs names and existing leases
drained.

Release note (sql change): Implement the `ALTER SCHEMA RENAME TO`
command.
craig bot pushed a commit that referenced this issue Aug 13, 2020
@yuzefovich @rohany
Merge #52313 #52349
b1359ad 
52313: colexec: add default comparison operator r=yuzefovich a=yuzefovich

Depends on #52315.

**colexec: add default comparison operators**

This commit introduces default comparison projection and selection
operators that handle all `tree.ComparisonExpr`s for which we don't
have optimized implementations. The main operators are very similar
to `defaultBuiltinFuncOperator`, but we also introduce optimized
adapter implementations from `tree.ComparisonExpr` to a vectorized
friendly model. Quick benchmarks show about 3.5x improvement in
speed of `IS DISTINCT FROM` projection operator against the wrapped
post-processing spec.

Addresses: #49781.

Release note (sql change): Vectorized execution engine now fully
supports comparison operators (things like `ILIKE`, `IS NOT DISTINCT FROM`,
`SIMILAR TO`, and several others).

**colexec: add support for Tuple expressions and clean up tests**

This commit adds support for `tree.Tuple` expressions which are
supported either by pre-evaluation during planning (and handling the
result as other constant values) if the tuple is constant or by planning
projection operators for each expression in the tuple and then using
newly-introduced `tupleProjOp` if the tuple expression is not constant.

The support required refactoring of IsNull* operators to template out special
"is tuple null" variants (because tuple have very peculiar null-handling
semantics). It also required that we fallback to the default comparison
operators on things that we have optimized support for (for example,
EQ), also because of the null-handling semantics.

It also improves the tests to handle datum-backed types better. Note
that a single unit test in `aggregators_test.go` has been switched to use
`types.TimeTZ` instead of `types.Jsonb` because of the differences in
order of `string`s and `json.JSON.String()` (the former is the
"expected" value whereas the latter is the actual; it was simpler to
switch the test to use a different datum-backed type).

Release note: None

52349: sql: implement `ALTER SCHEMA RENAME TO` r=rohany a=rohany

Fixes #50880.

This commit implements the `ALTER SCHEMA RENAME TO` command. It reuses
the existing schema change infrastructure to handle a more general case
of an arbitrary descriptor that just needs names and existing leases
drained.

Release note (sql change): Implement the `ALTER SCHEMA RENAME TO`
command.

Co-authored-by: Yahor Yuzefovich <[email protected]>
Co-authored-by: Rohan Yadav <[email protected]>
@craig craig bot closed this as completed in c644dc0 Aug 13, 2020
rohany added a commit to rohany/cockroach that referenced this issue Aug 13, 2020
@rohany
sql: implement ALTER SCHEMA RENAME TO
ae0bb60 
Fixes cockroachdb#50880.

This commit implements the `ALTER SCHEMA RENAME TO` command. It reuses
the existing schema change infrastructure to handle a more general case
of an arbitrary descriptor that just needs names and existing leases
drained.

Release note (sql change): Implement the `ALTER SCHEMA RENAME TO`
command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: implement ALTER SCHEMA RENAME TO rohany/cockroach
1 participant
@rohany