Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colexec: add support for Concat binary operator #49466

Closed
yuzefovich opened this issue May 23, 2020 · 0 comments · Fixed by #49758
Closed

colexec: add support for Concat binary operator #49466

yuzefovich opened this issue May 23, 2020 · 0 comments · Fixed by #49758
Labels
A-sql-vec SQL vectorized engine C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) good first issue

Comments

@yuzefovich
Copy link
Member

Add support for Concat binary operator. For more details, see #49463.
@yuzefovich yuzefovich added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) good first issue A-sql-vec SQL vectorized engine labels May 23, 2020
@yuzefovich yuzefovich mentioned this issue May 23, 2020
Closed
9 tasks
yongyanglai added a commit to yongyanglai/cockroach that referenced this issue Jun 1, 2020
@yongyanglai
colexec: add support for Concat binary operator
14f6d44 
Previously, the vectorized engine lacked support for concat binary
operator.
This commit added this support. I implemented concat for bytes
referrering to same operator for row-oriented egine. Since there was
already a "getBinOpAssignFunc" implemented for "datumCustomizer", I
just registered the output type for Concat operator for datum type, so
that Concat operator for datum type would be generated as expected.

Resolves: cockroachdb#49466
See also: cockroachdb#49463

Release note (sql change): None
@yongyanglai yongyanglai mentioned this issue Jun 1, 2020
Merged
@craig craig bot closed this as completed in 455a67b Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-sql-vec SQL vectorized engine C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

colexec: add support for Concat binary operator yongyanglai/cockroach
1 participant
@yuzefovich