Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add telemetry for interleaved table join if it doesn't already exist #39360

Closed
jordanlewis opened this issue Aug 6, 2019 · 2 comments · Fixed by #40914
Closed

sql: add telemetry for interleaved table join if it doesn't already exist #39360

jordanlewis opened this issue Aug 6, 2019 · 2 comments · Fixed by #40914
Assignees
@rohany
Labels
A-sql-execution Relating to SQL execution. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) S-3-productivity Severe issues that impede the productivity of CockroachDB developers.

Comments

@jordanlewis
Copy link
Member

Interleaved table join is one of the most complex features in the SQL system. We should determine if it's getting used or not.
@awoods187 awoods187 added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) S-3-productivity Severe issues that impede the productivity of CockroachDB developers. A-sql-execution Relating to SQL execution. labels Aug 30, 2019
@rohany
Copy link
Contributor

rohany commented Sep 19, 2019

Is this the interleaved_reader_joiner.go?

@jordanlewis
Copy link
Member Author

Yes.

@rohany rohany mentioned this issue Sep 19, 2019
Merged
@rohany rohany self-assigned this Sep 19, 2019
craig bot pushed a commit that referenced this issue Sep 24, 2019
Merge #40914
905068e 
40914: sql: Add telemetry for interleaved table join r=rohany a=rohany

Adds some telemetry for how often the interleaved table join operation
gets planned, under the key "sql.plan.interleaved-table-join".

Fixes #39360.

Release justification: Low risk monitoring improvement.

Release note: None

Co-authored-by: Rohan Yadav <[email protected]>
@craig craig bot closed this as completed in a8b7df5 Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohany rohany

Labels
A-sql-execution Relating to SQL execution. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) S-3-productivity Severe issues that impede the productivity of CockroachDB developers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: Add telemetry for interleaved table join rohany/cockroach
3 participants
@jordanlewis @rohany @awoods187