19.1 release blockers list

[andreimatei]

Possible blockers for the 19.1 release.

• roachtest: scaledata/distributed_semaphore/nodes=6 failed #34695 (Scaledata roachtest node crashing with “unexpected non-pending txn in augmentMetaLocked”) @andreimatei
• Fatal consistency check failed with 1 inconsistent replicas #35424 (Consistency violation crash on fixture import) @andreimatei / @tbg
• Nodes unable to start: cannot addReplicaInternalLocked; range ... has overlapping range  #35559 / storage: chaos during merges leads to overlapping range descriptors #33120 overlapping range descriptor after merge @bdarnell
• Panic runtime error: index out of range when running 6 node tpc-c without range merging #34241 racy access to ObservedTimestamps causing marshalling panics @nvanbenschoten
• Panic in MarshalTo(0xc13312b400, 0xc1541c14ec, 0x13, 0x13, 0x15, 0x2, 0x11) #35803 updated marshalling panic @nvanbenschoten
• roachtest: tpcc/nodes=3/w=max failed with foreign key violation #35812 TPCC index inconsistency @nvanbenschoten
• sql: schema changer crashes when table not configured with zone cfg #35988 schema change crash @vivekmenezes
• roachtest: filesystem_simulator child does not exist in files failure #36022 missing row during consistency check @nvanbenschoten
• stability: Rebalances must be atomic #12768 (comment) slow downreplication @bdarnell
• storage: replicated into unavailability #36025 poor replication decisions @ajwerner
• storage: node crashes with "Corruption: external file have non zero sequence number" error #36679 Corruption: external file have non zero sequence number @dt
• SQL: Creating an index produced disk stall error #36385 Creating an index produced disk stall error @dt
• sql: creating an index, user experienced OOM #36381 creating an index, user experienced OOM @dt
• schema: add a knob to control the speed of schema changes #36430 add a knob to control the speed of schema changes @lucy-zhang (we added a knob but it didn't slow things down @awoods187 )
• sql: table name cache is not populated after misses #36044 table name cache is not populated after misses
• sql: distsql backward compatibility was broken in 19.1 #36574 distsql backward compatibility fail
• roachtest: scrub/all-checks/tpcc/w=1000 failed #35986 (comment) check 3.3.2.4 fails in tpcc-1000 @bdarnell
• storage: prevent crash migrating from 19.1-beta into 19.1-rcX #36714 crash migrating from 19.1-beta to 19.1 @tbg
• roachtest: cdc/tpcc-1000/rangefeed=true failed #35142 closedts stalls resulting in changefeed stalls @danhhz
• sql: creating an index, user experienced OOM #36381 OOM with CREATE INDEX @vivekmenezes
• storage: consistency check failure during import #36861 consistency check failure during import @tbg, @andreimatei (fix is in, linked issue is still open pending more testing)
• sql: fatal storage/replica_corruption when running a schema change #36937 schema change (mvcc stats) replica corruption
• storage: range failed to catch up due to invalid term #37056 hung CREATE DATABASE due to replica with invalid term failing to catch up @ajwerner

[petermattis]

@tbg Does #34241 also warrant being on this list? It doesn't look like it is causing corruption, yet it is super suspicious.

[awoods187]

We need to add #35559 to this list (either addressing it or turning off range merging)

[tbg]

@petermattis yes, definitely.

…

On Sat, Mar 9, 2019, 15:37 Andy Woods ***@***.***> wrote: We need to add #35559 <#35559> to this list (either addressing it or turning off range merging) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#35554 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE135Pq8uAQ5nqd2n317PH9QlmESXdvLks5vU8ccgaJpZM4bl8kU> .

[knz]

We need to also look at all the tests currently skipped:

• some are related to key features (import CSV) - the skipped test may be hiding a bug
• some were designed to exercise stability - the skipped test may be hiding unstability

[tbg]

I updated the list with the merge bug and the marshaling panic.

[petermattis]

All of the release blockers were fixed, and 19.1 has been released.