Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workload/roachtest: implement --tolerate-retry-errors #141792

Open
srosenberg opened this issue Feb 20, 2025 · 1 comment
Open

workload/roachtest: implement --tolerate-retry-errors #141792

srosenberg opened this issue Feb 20, 2025 · 1 comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team

Comments

@srosenberg
Copy link
Member

srosenberg commented Feb 20, 2025

A number of existing roachtests execute workload(s) with --tolerate-errors while at the same time incorrectly assuming that the workload(s) will do something useful. Since --tolerate-errors is indiscriminate wrt to the type of error, i.e., it ignores all of them, this implies that in the worst case, it's tantamount to assert true. Instead, most, if not all, of these roachtests could be strengthened to use --tolerate-retry-errors which would skip only the errors concerning transaction retries [1]; these are colloquially known as "ambiguous errors" [2].

[1] https://www.cockroachlabs.com/docs/stable/transaction-retry-error-reference
[2] #107571

Jira issue: CRDB-48005

@srosenberg srosenberg added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team labels Feb 20, 2025
Copy link

blathers-crl bot commented Feb 20, 2025

cc @cockroachdb/test-eng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team
Projects
None yet
Development

No branches or pull requests

1 participant