-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workload: handle ambiguous errors #107571
Comments
cc @cockroachdb/test-eng |
This was referenced Jul 25, 2023
Since this has come up in the context of performance benchmarks, we should be careful not to retry excessively. In some sense, a benchmark becomes tainted since retries could yield to performance degradation. |
This was referenced Sep 22, 2023
This was referenced Oct 17, 2023
This was referenced Aug 2, 2024
At least one type of "incorrect ambiguous" error is described here: #129427. The short term fix for that issue is to tolerate errors, but this isn't a great general fix. |
This was referenced Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Clients are expected to handle ambiguous errors; for instance, see our own documentation:
Despite that, our very own
workload
does not handle these errors, leading to occasional roachtest failures that should not have happened.We want
workload
to be able to handle these errors whenever possible (retrying when safe to do so). It might not be possible to completely eliminate these errors from bubbling up to the caller every time; each workload should be updated independently.Jira issue: CRDB-30113
The text was updated successfully, but these errors were encountered: