Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workload: handle ambiguous errors #107571

Open
renatolabs opened this issue Jul 25, 2023 · 3 comments
Open

workload: handle ambiguous errors #107571

renatolabs opened this issue Jul 25, 2023 · 3 comments
Labels
A-testing Testing tools and infrastructure C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-testeng TestEng Team

Comments

@renatolabs
Copy link
Contributor

renatolabs commented Jul 25, 2023

Clients are expected to handle ambiguous errors; for instance, see our own documentation:

Despite that, our very own workload does not handle these errors, leading to occasional roachtest failures that should not have happened.

We want workload to be able to handle these errors whenever possible (retrying when safe to do so). It might not be possible to completely eliminate these errors from bubbling up to the caller every time; each workload should be updated independently.

Jira issue: CRDB-30113

@renatolabs renatolabs added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-testing Testing tools and infrastructure T-testeng TestEng Team labels Jul 25, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jul 25, 2023

cc @cockroachdb/test-eng

@srosenberg
Copy link
Member

Since this has come up in the context of performance benchmarks, we should be careful not to retry excessively. In some sense, a benchmark becomes tainted since retries could yield to performance degradation.

@andrewbaptist
Copy link
Contributor

At least one type of "incorrect ambiguous" error is described here: #129427. The short term fix for that issue is to tolerate errors, but this isn't a great general fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Testing tools and infrastructure C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-testeng TestEng Team
Projects
None yet
Development

No branches or pull requests

3 participants