Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: TestZipIncludeAndExcludeFilesDataDriven failed #138538

Closed
cockroach-teamcity opened this issue Jan 7, 2025 · 0 comments · Fixed by #138625
Closed

cli: TestZipIncludeAndExcludeFilesDataDriven failed #138538

cockroach-teamcity opened this issue Jan 7, 2025 · 0 comments · Fixed by #138625
Assignees
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-observability

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jan 7, 2025

cli.TestZipIncludeAndExcludeFilesDataDriven failed with artifacts on master @ ec6e761a7dc4df7f5f3fc90e53cde8f3c48d4e21:

debug/system.jobs.txt
debug/system.lease.txt
debug/system.locations.txt
debug/system.migrations.txt
debug/system.namespace.txt
debug/system.privileges.txt
debug/system.protected_ts_meta.txt
debug/system.protected_ts_records.txt
debug/system.rangelog.txt
debug/system.replication_constraint_stats.txt
debug/system.replication_critical_localities.txt
debug/system.replication_stats.txt
debug/system.reports_meta.txt
debug/system.role_id_seq.txt
debug/system.role_members.txt
debug/system.role_options.txt
debug/system.scheduled_jobs.txt
debug/system.settings.txt
debug/system.span_configurations.txt
debug/system.sql_instances.txt
debug/system.sql_stats_cardinality.txt
debug/system.sqlliveness.txt
debug/system.statement_diagnostics.txt
debug/system.statement_diagnostics_requests.txt
debug/system.statement_statistics_limit_5000.txt
debug/system.table_statistics.txt
debug/system.task_payloads.txt
debug/system.tenant_settings.txt
debug/system.tenant_tasks.txt
debug/system.tenant_usage.txt
debug/system.tenants.txt
debug/tenant_ranges.err.txt
    zip_test.go:1453: -- test log scope end --
    datadriven.go:144: 
        testdata/zip/file-filters/testzip_file_filters:2:
         
        output didn't match expected:
        @@ -66,10 +66,11 @@
         debug/nodes/1/crdb_internal.node_txn_execution_insights.txt
         debug/nodes/1/crdb_internal.node_txn_stats.txt
         debug/nodes/1/details.json
         debug/nodes/1/gossip.json
         debug/nodes/1/heap.pprof
        +debug/nodes/1/heapprof/memprof.2025-01-07T18_16_21.428.132126856.pprof
         deterministic.log
         debug/nodes/1/lsm.txt
         debug/nodes/1/ranges.json
         debug/nodes/1/stacks.txt
         debug/nodes/1/stacks_with_labels.txt
    --- FAIL: TestZipIncludeAndExcludeFilesDataDriven/testzip_file_filters (22.74s)
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/obs-prs @cockroachdb/server @cockroachdb/obs-india-prs

This test on roachdash | Improve this report!

Jira issue: CRDB-46161

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-observability labels Jan 7, 2025
@arjunmahishi arjunmahishi self-assigned this Jan 8, 2025
craig bot pushed a commit that referenced this issue Jan 8, 2025
138625: pkg/cli: fix TestZipIncludeAndExcludeFilesDataDriven flakiness r=aa-joshi a=arjunmahishi

Fixes #138538
Epic: none
Release note: None

Co-authored-by: Arjun Mahishi <[email protected]>
@craig craig bot closed this as completed in 0437962 Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-observability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants