Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distsql: make TestLogicDistSQL run on a 3-node cluster w/fake span resolver #13377

Closed
2 of 5 tasks
RaduBerinde opened this issue Feb 2, 2017 · 1 comment
Closed
2 of 5 tasks

distsql: make TestLogicDistSQL run on a 3-node cluster w/fake span resolver #13377

RaduBerinde opened this issue Feb 2, 2017 · 1 comment
Assignees
@RaduBerinde
Milestone
Q1 2017

Comments

@RaduBerinde
Copy link
Member

RaduBerinde commented Feb 2, 2017 •
edited
Loading

List of issues blocking this:
@RaduBerinde RaduBerinde self-assigned this Feb 2, 2017
RaduBerinde added a commit to RaduBerinde/cockroach that referenced this issue Feb 2, 2017
@RaduBerinde
distsql: plumb use of fake span resolver
bc83a86 
To create a fake span resolver, we need information (nodeIDs, addresses) from
all the nodes in the cluster. This prevents us from being able to pass one in
the testing knobs, as these need to be populated before server start.

Plumbing down calls to set the fake span resolver after the cluster is created.

We don't yet enable multi-node on TestLogicDistSQL (see cockroachdb#13377).
@RaduBerinde RaduBerinde mentioned this issue Feb 2, 2017
Closed
RaduBerinde added a commit to RaduBerinde/cockroach that referenced this issue Feb 7, 2017
@RaduBerinde
distsql: plumb use of fake span resolver
4226864 
To create a fake span resolver, we need information (nodeIDs, addresses) from
all the nodes in the cluster. This prevents us from being able to pass one in
the testing knobs, as these need to be populated before server start.

Plumbing down calls to set the fake span resolver after the cluster is created.

We don't yet enable multi-node on TestLogicDistSQL (see cockroachdb#13377).
RaduBerinde added a commit to RaduBerinde/cockroach that referenced this issue Feb 8, 2017
@RaduBerinde
distsql: plumb use of fake span resolver
3d828bb 
To create a fake span resolver, we need information (nodeIDs, addresses) from
all the nodes in the cluster. This prevents us from being able to pass one in
the testing knobs, as these need to be populated before server start.

Plumbing down calls to set the fake span resolver after the cluster is created.

We don't yet enable multi-node on TestLogicDistSQL (see cockroachdb#13377).
@RaduBerinde RaduBerinde mentioned this issue Feb 18, 2017
Closed
18 tasks
@cuongdo cuongdo added this to the Q1 2017 milestone Feb 22, 2017
@RaduBerinde
Copy link
Member Author

This has been enabled with workarounds for the outstanding issues (which are tracked separately).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaduBerinde RaduBerinde

Labels
None yet
Projects
None yet
Milestone
Q1 2017
Development

No branches or pull requests
2 participants
@cuongdo @RaduBerinde