Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/stmtdiagnostics: TestDiagnosticsRequest failed #119945

Closed
cockroach-teamcity opened this issue Mar 5, 2024 · 4 comments
Closed

sql/stmtdiagnostics: TestDiagnosticsRequest failed #119945

cockroach-teamcity opened this issue Mar 5, 2024 · 4 comments
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-queries SQL Queries Team
Milestone
24.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Mar 5, 2024 •
edited by cockroach-jira-scripts
Loading

sql/stmtdiagnostics.TestDiagnosticsRequest failed with artifacts on master @ 1516e36763dbb1ed8413a12bf01082fef2fb03a1:

=== RUN   TestDiagnosticsRequest
    test_log_scope.go:170: test logs captured to: /artifacts/tmp/_tmp/cb4e70d2cc4a901d2a7689654ffd0100/logTestDiagnosticsRequest432867545
    test_log_scope.go:81: use -show-logs to present logs inline
    statement_diagnostics_test.go:540: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/cb4e70d2cc4a901d2a7689654ffd0100/logTestDiagnosticsRequest432867545
--- FAIL: TestDiagnosticsRequest (184.78s)
=== RUN   TestDiagnosticsRequest/plan-gist_matching
    statement_diagnostics_test.go:487: error executing query="ANALYZE large;" args=[]: pq: context canceled
    --- FAIL: TestDiagnosticsRequest/plan-gist_matching (121.35s)

Parameters:

  • TAGS=bazel,gss
  • stress=true
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-36406
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team labels Mar 5, 2024
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone Mar 5, 2024
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Mar 5, 2024
@mgartner
Copy link
Collaborator

mgartner commented Mar 5, 2024

Looks like analyzing a table with 10,000 rows timed-out after 120s. That's very slow. @rickystewart was there a recent test infrastructure change that could case this? I saw #119953—maybe that is related.

@rickystewart
Copy link
Collaborator

@mgartner No, no recent infrastructural change. #119953 is un-related as that PR is specifically for race and deadlock tests, which this is not.

Looks like this test only has 1 core right now. We could give it an additional core by running it on the large pool. Seem reasonable to you?

@yuzefovich
Copy link
Member

Sounds reasonable to me. We could also reduce the row count without losing the test coverage - I'll send a patch for that.

@yuzefovich yuzefovich mentioned this issue Mar 6, 2024
Merged
@yuzefovich yuzefovich removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Mar 6, 2024
craig bot pushed a commit that referenced this issue Mar 6, 2024
@yuzefovich
Merge #119981 #119986
ce5f34e 
119981: stmtdiagnostics: reduce row count in a test r=yuzefovich a=yuzefovich

We can go from 10k to 100 for the large table while still getting the desired plans.

Informs: #119945

Epic: None

Release note: None

119986: sql: enhance error messages on validation of rows in virtual tables r=yuzefovich a=yuzefovich

We just saw an internal error when populating `crdb_internal.cluster_locks` virtual table that was missing important bits (the column name) to understand what happens. Since names of virtual tables and columns in them don't contain PII, they are safe for redaction.

Epic: None

Release note: None

Co-authored-by: Yahor Yuzefovich <[email protected]>
@mgartner
Copy link
Collaborator

mgartner commented Mar 6, 2024

I think we can close this and assume #119981 fixes this, unless it pops up again.

@mgartner mgartner closed this as completed Mar 6, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in SQL Queries Mar 6, 2024
@nvanbenschoten nvanbenschoten mentioned this issue Mar 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
24.1
Development

No branches or pull requests
4 participants
@mgartner @rickystewart @yuzefovich @cockroach-teamcity