roachtest: multitenant/distsql/instances=20/bundle=off/timeout=1 failed #100260
Assignees
Labels
A-kv
Anything in KV that doesn't belong in a more specific category.
branch-master
Failures and bugs on the master branch.
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
C-test-failure
Broken test (automatically or manually discovered).
O-roachtest
O-robot
Originated from a bot.
skipped-test
T-kv
KV Team
Milestone
Comments
cockroach-teamcity
added
branch-master
|
roachtest.multitenant/distsql/instances=20/bundle=off/timeout=1 failed with artifacts on master @ 41581c367b3a1d7893c2945465c57ffa841035e3: Parameters: |
This was referenced Mar 31, 2023
|
roachtest.multitenant/distsql/instances=20/bundle=off/timeout=1 failed with artifacts on master @ 99102ddf4b7602788b422366f1acc14b81c64d24: Parameters: |
|
roachtest.multitenant/distsql/instances=20/bundle=off/timeout=1 failed with artifacts on master @ 99102ddf4b7602788b422366f1acc14b81c64d24: Parameters: |
|
roachtest.multitenant/distsql/instances=20/bundle=off/timeout=1 failed with artifacts on master @ 1e27c65fb5a3810a5e2285cf07b45d95d401cca6: Parameters: |
|
roachtest.multitenant/distsql/instances=20/bundle=off/timeout=1 failed with artifacts on master @ 1e27c65fb5a3810a5e2285cf07b45d95d401cca6: Parameters: |
|
roachtest.multitenant/distsql/instances=20/bundle=off/timeout=1 failed with artifacts on master @ 1e27c65fb5a3810a5e2285cf07b45d95d401cca6: Parameters: |
This was referenced Apr 3, 2023
Could we set the min first, then do a |
|
That command just fails even when run directly in the shell for an unloaded test cluster: ...but it can't be done separately, either: So I think we just have to figure out why #99759 didn't work. |
mgartner
removed
the
release-blocker
|
This is not a release-blocker. |
This was referenced Apr 3, 2023
craig bot
pushed a commit
that referenced
this issue
Apr 3, 2023
99858: screl: Add IndexID as a attr of UniqueWithoutIndex element r=Xiang-Gu a=Xiang-Gu Previously, ALTER TABLE stmt where we add column/drop column/alter PK and adding a unique without index is problematic in that the it can succeed even when there are duplicate values. We already had a dep rule that enforces the new primary index to be backfilled before we validate the constraint against it. Unfortunately, this rule is not enforced on unique without index constraint because IndexID was not a attr of it. This commit fixes this. Fixes #99281 Epic: None Release note (bug fix): Fixed a bug in v23.1 in the declarative schema changer where unique without index can be incorrectly added in tables with duplicate values if it's with a ADD/DROP COLUMN in one ALTER TABLE statement. 100357: sql: allow changing the number of histogram samples and buckets r=rytaft a=rytaft Informs #72418 Informs #97701 Release note (sql change): Added two new cluster settings that enable users to change the number of histogram samples and buckets collected when building histograms as part of table statistics collection: `sql.stats.histogram_samples.count` and `sql.stats.histogram_buckets.count`. While the default values should work for most cases, it may be beneficial to increase the number of samples and buckets for very large tables to avoid creating a histogram that misses important values. 100489: go.mod: bump Pebble to b84a7ec7d8dc r=RaduBerinde a=jbowens ``` b84a7ec7 db: populate return statistics for flushable ingests 5fd58365 objstorage: implement tracing 7f7451f2 db,record: add BatchCommitStats to measure total and component durations for commit 295aaab0 objstorage: implement basic refcounting ``` Epic: None Release note: None 100516: multiregionccl: reenable TestMrSystemDatabase r=ajwerner a=ajwerner I stressed this for a long time on many cores and it did not fail. Epic: none Fixes: #98039 Release note: None 100527: roachtest: skip multitenant/distsql for now r=yuzefovich a=yuzefovich Informs: #100260. Epic: None Release note: None Co-authored-by: Xiang Gu <[email protected]> Co-authored-by: Rebecca Taft <[email protected]> Co-authored-by: Jackson Owens <[email protected]> Co-authored-by: Andrew Werner <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]>
I left a comment on that PR; I think the env var needs to be passed to the command that starts the tenant. |
pav-kv
added
C-bug
|
I see that the test is dropping the max range size in order to create a large number of splits. Does someone who is familiar with this test (maybe @cucaroach, its author) know why this approach was taken, as opposed to manually splitting ranges using |
|
Setting the max range size was the only thing that occurred to me from what I can recall. I'm basically inserting rows and waiting for the number of ranges to grow high enough for distsql to hit all nodes and I wanted to get there as expediently as possible. |
|
@renatolabs your argument appears to be valid, I confirmed locally. By passing I'll address the differences between [1] #105006 |
craig bot
pushed a commit
that referenced
this issue
Jun 19, 2023
105006: roachtest: multi-tenant distributed sql fix r=srosenberg,renatolabs a=herkolategan This change fixes the `multitenant_distsql` test by passing `COCKROACH_MIN_RANGE_MAX_BYTES` as part of the env vars when starting tenants as well. The code around port handling on local clusters have also been updated to avoid collisions. There is a mechanism in place to offset the ports, but it still clashed with local ports from other nodes created before the tenants, so a simple naive shift has been put in place. Fixes: #100260 Epic: None Co-authored-by: Herko Lategan <[email protected]>
herkolategan
added a commit
to herkolategan/cockroach
that referenced
this issue
Jun 23, 2023
This change fixes the `multitenant_distsql` test by passing `COCKROACH_MIN_RANGE_MAX_BYTES` as part of the env vars when starting tenants as well. The code around port handling on local clusters have also been updated to avoid collisions. There is a mechanism in place to offset the ports, but it still clashed with local ports from other nodes created before the tenants, so a simple naive shift has been put in place. Fixes: cockroachdb#100260 Epic: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
roachtest.multitenant/distsql/instances=20/bundle=off/timeout=1 failed with artifacts on master @ 41581c367b3a1d7893c2945465c57ffa841035e3:
Parameters:
ROACHTEST_cloud=gce,ROACHTEST_cpu=4,ROACHTEST_encrypted=false,ROACHTEST_ssd=0Help
See: roachtest README
See: How To Investigate (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-26328
The text was updated successfully, but these errors were encountered: