Skip to content

Commit

Permalink
acceptance: de-flake test_missing_log_output
Browse files Browse the repository at this point in the history
...by filtering out all GRPC log messages.

Fixes #19397.
Fixes #19388.
  • Loading branch information
tbg authored and tamird committed Oct 20, 2017
1 parent d41bab2 commit d0e58d2
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions pkg/cli/interactive_tests/test_missing_log_output.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ start_test "Test that quit does not emit unwanted logging output"
# Unwanted: between the point the command starts until it
# either prints the final ok message or fails with some error
# (e.g. due to no definite answer from the server).
send "echo marker; $argv quit 2>&1 | grep '^\\(\[IWEF\]\[0-9\]\\)' \r"
send "echo marker; $argv quit 2>&1 | grep -vE '^\[IWEF\]\[0-9\]+ .\* grpc: '\r"
set timeout 20
eexpect "marker\r\n:/# "
set timeout 5
Expand All @@ -87,11 +87,7 @@ start_test "Test that quit does not show INFO by defaults with --logtostderr"
# that the default logging level is WARNING, so that no INFO messages
# are printed between the marker and the (first line) error message
# from quit. Quit will error out because the server is already stopped.
#
# Since quit is likely to actually emit warnings, but we are just
# interested in the absence of INFO messages, remove the warnings from
# the output.
send "echo marker; $argv quit --logtostderr 2>&1 | grep -v '^W'\r"
send "echo marker; $argv quit --logtostderr 2>&1 | grep -vE '^\[IWEF\]\[0-9\]+ .\* grpc: '\r"
eexpect "marker\r\nError"
eexpect ":/# "
end_test
Expand Down

0 comments on commit d0e58d2

Please sign in to comment.