Merge #138163

138163: ui: remove disused fields from jobs page r=dt a=dt These values pertained to a deprecated and sinced removed retry/backoff mechanism, and are no longer populated so it does not make sense to show them. Release note: none. Epic: none. Co-authored-by: David Taylor <[email protected]>
cockroachdb · Jan 5, 2025 · 95b377e · 95b377e
2 parents 6e405b0 + c966ef7
commit 95b377e
Showing 1 changed file with 2 additions and 34 deletions.
diff --git a/pkg/ui/workspaces/cluster-ui/src/jobs/jobDetailsPage/jobDetails.tsx b/pkg/ui/workspaces/cluster-ui/src/jobs/jobDetailsPage/jobDetails.tsx
@@ -146,11 +146,7 @@ export class JobDetails extends React.Component<
     );
   };
 
-  renderOverviewTabContent = (
-    hasNextRun: boolean,
-    nextRun: moment.Moment,
-    job: JobResponse,
-  ): React.ReactElement => {
+  renderOverviewTabContent = (job: JobResponse): React.ReactElement => {
     if (!job) {
       return null;
     }
@@ -165,19 +161,6 @@ export class JobDetails extends React.Component<
                 <JobStatusCell job={job} lineWidth={1.5} hideDuration={true} />
               }
             />
-            {hasNextRun && (
-              <>
-                <SummaryCardItem
-                  label="Next Planned Execution Time"
-                  value={
-                    <Timestamp
-                      time={nextRun}
-                      format={DATE_WITH_SECONDS_AND_MILLISECONDS_FORMAT_24_TZ}
-                    />
-                  }
-                />
-              </>
-            )}
             <SummaryCardItem
               label="Creation Time"
               value={
@@ -209,19 +192,6 @@ export class JobDetails extends React.Component<
                 }
               />
             )}
-            <SummaryCardItem
-              label="Last Execution Time"
-              value={
-                <Timestamp
-                  time={TimestampToMoment(job.last_run, null)}
-                  format={DATE_WITH_SECONDS_AND_MILLISECONDS_FORMAT_24_TZ}
-                />
-              }
-            />
-            <SummaryCardItem
-              label="Execution Count"
-              value={String(job.num_runs)}
-            />
             <SummaryCardItem label="User Name" value={job.username} />
             {job.highwater_timestamp && (
               <SummaryCardItem
@@ -258,8 +228,6 @@ export class JobDetails extends React.Component<
       this.props.jobRequest.inFlight && !this.props.jobRequest.data;
     const error = this.props.jobRequest.error;
     const job = this.props.jobRequest.data;
-    const nextRun = TimestampToMoment(job?.next_run);
-    const hasNextRun = nextRun?.isAfter();
     const { currentTab } = this.state;
     return (
       <div className={jobCx("job-details")}>
@@ -304,7 +272,7 @@ export class JobDetails extends React.Component<
                   activeKey={currentTab}
                 >
                   <TabPane tab={TabKeysEnum.OVERVIEW} key="overview">
-                    {this.renderOverviewTabContent(hasNextRun, nextRun, job)}
+                    {this.renderOverviewTabContent(job)}
                   </TabPane>
                   {!useContext(CockroachCloudContext) &&
                     this.props.hasAdminRole && (