Skip to content

Commit

Permalink
sqlstats: skip TestTransactionServiceLatencyOnExtendedProtocol
Browse files Browse the repository at this point in the history
Skip this test until we fix the data race caused by the
testing knob functions.

Epic: none

Release note: None
  • Loading branch information
xinhaoz committed Mar 6, 2024
1 parent a2420ac commit 7a9011a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions pkg/sql/sqlstats/sslocal/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ go_test(
"//pkg/sql/sqlstats/ssmemstorage",
"//pkg/testutils",
"//pkg/testutils/serverutils",
"//pkg/testutils/skip",
"//pkg/testutils/sqlutils",
"//pkg/testutils/testcluster",
"//pkg/util",
Expand Down
2 changes: 2 additions & 0 deletions pkg/sql/sqlstats/sslocal/sql_stats_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/sql/sqlstats/ssmemstorage"
"github.com/cockroachdb/cockroach/pkg/testutils"
"github.com/cockroachdb/cockroach/pkg/testutils/serverutils"
"github.com/cockroachdb/cockroach/pkg/testutils/skip"
"github.com/cockroachdb/cockroach/pkg/testutils/sqlutils"
"github.com/cockroachdb/cockroach/pkg/util"
"github.com/cockroachdb/cockroach/pkg/util/ctxgroup"
Expand Down Expand Up @@ -712,6 +713,7 @@ func TestUnprivilegedUserReset(t *testing.T) {
func TestTransactionServiceLatencyOnExtendedProtocol(t *testing.T) {
defer leaktest.AfterTest(t)()
defer log.Scope(t).Close(t)
skip.WithIssue(t, 119580)
ctx := context.Background()

testData := []*struct {
Expand Down

0 comments on commit 7a9011a

Please sign in to comment.