Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

images: Don't install selinux-policy-default on the Debians #7472

Merged
merged 2 commits into from
Feb 24, 2025
Merged

images: Don't install selinux-policy-default on the Debians #7472

merged 2 commits into from
Feb 24, 2025

Conversation

mvollmer
Copy link
Member

@mvollmer mvollmer commented Feb 24, 2025 •
edited by martinpitt
Loading

We don't enable SELinux and it can't currently be installed in debian-testing.

  • image-refresh debian-testing

Fixes #7454

@mvollmer mvollmer added the bot label Feb 24, 2025
@cockpituous cockpituous changed the title images: Don't install selinux-policy-default on the Debians WIP: 6b7caf96cb5c: [no-test] images: Don't install selinux-policy-default on the Debians Feb 24, 2025
@cockpituous
Copy link
Contributor

image-refresh debian-testing done: https://github.com/cockpit-project/bots/commits/image-refresh-debian-testing-20250224-091514

@cockpituous
Copy link
Contributor

Success. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-debian-testing-283d4d2f-20250224-090149/log.html

@cockpituous cockpituous changed the title WIP: 6b7caf96cb5c: [no-test] images: Don't install selinux-policy-default on the Debians images: Don't install selinux-policy-default on the Debians Feb 24, 2025
@cockpituous cockpituous changed the title images: Don't install selinux-policy-default on the Debians WIP: 3b48f4b52050: [no-test] images: Don't install selinux-policy-default on the Debians Feb 24, 2025
martinpitt
martinpitt reviewed Feb 24, 2025
View reviewed changes
images/scripts/debian.setup Outdated
Comment on lines 103 to 104
DENIED_PACKAGES="\
selinux-policy-default-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we limit this to debian-testing? It doesn't get in the way on the other OSes, so we shouldn't modify more than necessary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but it might get in the way in the future... less selinux is more, no? :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, not a strong opinion. I even wonder what brings it in.

@cockpituous
Copy link
Contributor

image-refresh ubuntu-stable done: https://github.com/cockpit-project/bots/commits/image-refresh-ubuntu-stable-20250224-093105

@cockpituous cockpituous changed the title WIP: 3b48f4b52050: [no-test] images: Don't install selinux-policy-default on the Debians images: Don't install selinux-policy-default on the Debians Feb 24, 2025
@cockpituous
Copy link
Contributor

Success. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-ubuntu-stable-283d4d2f-20250224-091522/log.html

@mvollmer mvollmer mentioned this pull request Feb 24, 2025
Closed
1 task
@mvollmer mvollmer force-pushed the images-debian-deny-selinux branch from 283d4d2 to 2cae63a Compare February 24, 2025 09:40
@cockpituous cockpituous changed the title images: Don't install selinux-policy-default on the Debians WIP: 219c0d0814c8: [no-test] images: Don't install selinux-policy-default on the Debians Feb 24, 2025
@cockpituous
Copy link
Contributor

image-refresh debian-testing done: https://github.com/cockpit-project/bots/commits/image-refresh-debian-testing-20250224-095414

@cockpituous cockpituous changed the title WIP: 219c0d0814c8: [no-test] images: Don't install selinux-policy-default on the Debians images: Don't install selinux-policy-default on the Debians Feb 24, 2025
@cockpituous
Copy link
Contributor

Success. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-debian-testing-2cae63a4-20250224-094058/log.html

martinpitt
martinpitt requested changes Feb 24, 2025
View reviewed changes
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinpitt
Copy link
Member

@mvollmer When you force-push, please also add "Fixes #7454" to the commit message.

mvollmer and others added 2 commits February 24, 2025 12:48
@mvollmer
images: Don't install selinux-policy-default on debian-testing
c132b76 
We don't enable SELinux and it can't currently be installed in
debian-testing.

Fixes cockpit-project#7454
@mvollmer
images: Update debian-testing image
243953b
@mvollmer mvollmer force-pushed the images-debian-deny-selinux branch from 913b18d to 243953b Compare February 24, 2025 10:49
@mvollmer
Copy link
Member Author

Tests were green on 913b18d

martinpitt
martinpitt approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@martinpitt martinpitt marked this pull request as ready for review February 24, 2025 10:51
@martinpitt martinpitt merged commit 61c1039 into cockpit-project:main Feb 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpitt martinpitt martinpitt approved these changes

Assignees
No one assigned
Labels
bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image refresh for debian-testing
3 participants
@mvollmer @cockpituous @martinpitt