Fix: Incorrect error thrown when missing chrome/geckodriver

splinter/browser.py

@@ -59,13 +59,15 @@ def get_driver(driver, retry_count=3, *args, **kwargs):
     This can mitigate issues running on Remote WebDriver.
 
     """
+    err = None
+
     for _ in range(retry_count):
         try:
             return driver(*args, **kwargs)
         except (IOError, HTTPException, WebDriverException, MaxRetryError) as e:
-            pass
+            err = e
 
-    raise e
+    raise err
 
 
 def Browser(driver_name="firefox", retry_count=3, *args, **kwargs):

tests/test_browser.py

@@ -13,6 +13,10 @@
 
 from splinter.exceptions import DriverNotFoundError
 
+from selenium.common.exceptions import WebDriverException
+
+import pytest
+
 from .fake_webapp import EXAMPLE_APP
 
 
@@ -57,3 +61,14 @@ def test_should_raise_an_exception_when_browser_driver_is_not_found(self):
             from splinter import Browser
 
             Browser("unknown-driver")
+
+
+@pytest.mark.parametrize('browser_name', ['chrome', 'firefox'])
+def test_local_driver_not_present(browser_name):
+    """When chromedriver/geckodriver are not present on the system."""
+    from splinter import Browser
+
+    with pytest.raises(WebDriverException) as e:
+        Browser(browser_name, executable_path='failpath')
+
+    assert "Message: 'failpath' executable needs to be in PATH." in str(e.value)