Accept all valid arguments for Remote WebDriver #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsmedina
requested changes
Nov 22, 2019
splinter/driver/webdriver/remote.py
Outdated
Comment on lines
36
to
41
| if not kwargs.get('desired_capabilities'): | ||
| kwargs['desired_capabilities'] = caps | ||
| else: | ||
| # Combine user's desired capabilities with default | ||
| caps.update(kwargs['desired_capabilities']) | ||
| kwargs['desired_capabilities'] = caps |
There was a problem hiding this comment.
This code can be simplified:
if kwargs.get('desired_capabilities'):
# Combine user's desired capabilities with default
caps.update(kwargs['desired_capabilities'])
kwargs['desired_capabilities'] = caps
There was a problem hiding this comment.
@andrewsmedina Good catch. Fixed.
andrewsmedina
approved these changes
Nov 28, 2019
|
@jsfehler thanks for contribute |
cheezeygeek
added a commit
to cheezeygeek/splinter
that referenced
this pull request
Jan 30, 2020
* Fix Firefox headless mode to handle custom firefox_binary option (cobrateam#714) * Firefox headless mode handles custom firefox_binary option, if it is set * Use six to handle Python 2/3 compatibility * How to fill in complex text values (cobrateam#716) * Fix Firefox driver to respect headless option in subsequent calls (cobrateam#715) * Firefox headless mode handles custom firefox_binary option, if it is set * Use six to handle Python 2/3 compatibility * Fix Firefox driver to respect headless option in subsequent calls * Fix the test to explicitly launch browser in headless mode * Browser.get_alert() returns None if no alert exists (cobrateam#717) * Adds code highlight to the README.rst (cobrateam#720) * add in docs the possibility to use selenium (cobrateam#722) * added docs for is_element_visible methods (cobrateam#723) * Retry WebElement.click if ElementClickInterceptedException or WebDriverException is thrown (cobrateam#725) * find_by_x methods in WebDriverElement now uses retry mechanism (cobrateam#727) * Fixed dead external links (cobrateam#731) * Fixed dead external links * Fixed more dead in docs/community.rst * is_not_present/visible returns True immediately after not finding anything (cobrateam#732) * Update version of Firefox and geckodriver used for tests (cobrateam#737) * Accept all valid arguments for Remote WebDriver (cobrateam#734) * Accept all valid arguments for Remote WebDriver * fixup * Allow ActionChains when using Remote WebDriver (cobrateam#738) * add docs about 0.12.0 * setup: bump to 0.12.0 * docs for 0.12.0 * removing circle ci config * Patch Remote WebDriver to add retry attempts. Add retry to Browser init. (cobrateam#742) * Refactor forward/back tests to run in isolation (cobrateam#741) * Add driver attribute to WebDriverElement (cobrateam#740) * use python 3.8 instead 3.8-3.8-3.8-dev * Fix WebElement.select and .select_by_text to search only inside the parent element (cobrateam#729) * Refactor some chrome/firefox tests to use pytest (cobrateam#735) * find_by with 0 second wait_time only checks once (cobrateam#739) * Fix FlaskClient redirects (cobrateam#721) * Fix FlaskClient redirects (cobrateam#515) Update to the `FlaskClient` driver to make 302/303 redirects behave as expected (e.g to use GET to request the location in the resposne) and to ensure that data submit using GET is done so as arguments in the URL instead of through the `data` argument. * Add test for Flask redirect of POST response (cobrateam#515) * WebDriverElement find_by_x methods now take wait_time argument (cobrateam#744) * add docs about 0.13.0 release * setup: bump to 0.13.0 * make find_by_value works with btn elements (cobrateam#746) * make find_by_value works with btn elements closes cobrateam#274 * fix find_by_value for button elements for zope * fix find_by_value in chrome * Fix: Incorrect error thrown when missing chrome/geckodriver (cobrateam#749) * Fix scenario where incorrect error is thrown when missing chrome/geckodriver * Fixup * add a test to ensure that cobrateam#361 is already fixed * fix test in python3 Co-authored-by: Kasse Korhonen <[email protected]> Co-authored-by: Mikko Ohtamaa <[email protected]> Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: George <[email protected]> Co-authored-by: sukhbeersingh <[email protected]> Co-authored-by: Joshua Fehler <[email protected]> Co-authored-by: Johan Niklasson <[email protected]> Co-authored-by: Andrews Medina <[email protected]> Co-authored-by: Laurence de Bruxelles <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the Remote Browser from accepting desired capabilities in the keyword args to accepting anything and sending to Remote Webdriver as keyword args. As a result, desired capabilities are now sent as a dictionary instead of keyword args.
Documentation updated to reflect the new behaviour.