Fix ElementList.__getattr__() to no longer hide ElementNotFound #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When elements aren't found on the page, calling methods like ElementList.click() don't raise ElementNotFound. Instead it would report "AttributeError: 'ElementList' object has no attribute 'click'" The current behavior is confusing because it reports the wrong error. Users start looking why there is an AttributeError instead of noticing that the ElementNotFound exception was the actual cause.
andrewsmedina
approved these changes
Jul 29, 2019
|
@vdboor thanks for contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When elements aren't found on the page, calling methods like ElementList.click() didn't raise this error. Instead it would report "AttributeError: 'ElementList' object has no attribute 'click'" which confuses users to look at other places than the actual error.