Add WebDriverElement.is_visible() and WebDriverElement.is_not_visible() #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates browser.is_element_visible_by_css/xpath, which were never part of the DriverAPI.
This behaviour is moved into the Element. Unlike checking for an element to be present, to check for an element to be visible it must already exist. Thus
browser.find_by_css("foo").is_visible()better represents what the user is doing, and most likely what they want to do. This also removes the need forby_css,by_xpath, etc methods, since that decision is already made before the call to the method.