is_element_(not_)_visible: Check for StaleElementReferenceException

cobrateam · Jul 29, 2021 · 9a776f4 · 9a776f4
1 parent 75c790b
commit 9a776f4
Showing 1 changed file with 29 additions and 4 deletions.
diff --git a/splinter/driver/webdriver/__init__.py b/splinter/driver/webdriver/__init__.py
@@ -335,18 +335,43 @@ def is_element_visible(self, finder, selector, wait_time=None):
         end_time = time.time() + wait_time
 
         while time.time() < end_time:
-            if finder(selector, wait_time=wait_time) and finder(selector, wait_time=wait_time).visible:
+            try:
+                if finder(selector, wait_time=wait_time) and finder(selector, wait_time=wait_time).visible:
+                    return True
                 return True
+            except ValueError:
+                pass
+            except NoSuchElementException:
+                # This exception will be thrown if the body tag isn't present
+                # This has occasionally been observed. Assume that the
+                # page isn't fully loaded yet
+                pass
+            except StaleElementReferenceException:
+                # This exception is sometimes thrown if the page changes
+                # quickly
+                pass
         return False
 
     def is_element_not_visible(self, finder, selector, wait_time=None):
         wait_time = wait_time or self.wait_time
         end_time = time.time() + wait_time
 
         while time.time() < end_time:
-            element = finder(selector, wait_time=0)
-            if not element or (element and not element.visible):
-                return True
+            try:
+                element = finder(selector, wait_time=0)
+                if not element or (element and not element.visible):
+                    return True
+            except ValueError:
+                pass
+            except NoSuchElementException:
+                # This exception will be thrown if the body tag isn't present
+                # This has occasionally been observed. Assume that the
+                # page isn't fully loaded yet
+                pass
+            except StaleElementReferenceException:
+                # This exception is sometimes thrown if the page changes
+                # quickly
+                pass
         return False
 
     def is_element_visible_by_css(self, css_selector, wait_time=None):