Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should search default packages when text is empty #623

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

Beace
Copy link
Contributor

@Beace Beace commented Dec 15, 2023

当搜索关键词为空时,不进行 ES 关键词搜索拼接,返回一个默认的全量数据排名。 close #622

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 167 lines in your changes are missing coverage. Please review.

Comparison is base (6624a36) 97.45% compared to head (244c06a) 96.83%.
Report is 145 commits behind head on master.

Files Patch % Lines
config/config.default.ts 53.03% 31 Missing ⚠️
.../port/controller/admin/PaddingVersionController.ts 48.83% 22 Missing ⚠️
app/core/service/FixNoPaddingVersionService.ts 54.54% 15 Missing ⚠️
app/core/service/PackageSearchService.ts 93.72% 15 Missing ⚠️
app/core/service/PackageSyncerService.ts 85.84% 15 Missing ⚠️
app/port/schedule/SyncBinaryWorker.ts 21.42% 11 Missing ⚠️
app/repository/PackageVersionRepository.ts 87.95% 10 Missing ⚠️
app/core/service/PackageVersionFileService.ts 91.48% 8 Missing ⚠️
app/core/entity/PaddingSemVer.ts 88.00% 6 Missing ⚠️
app/core/service/PackageVersionService.ts 94.91% 6 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #623      +/-   ##
==========================================
- Coverage   97.45%   96.83%   -0.62%     
==========================================
  Files         168      180      +12     
  Lines       15691    17551    +1860     
  Branches     2018     2285     +267     
==========================================
+ Hits        15291    16996    +1705     
- Misses        400      555     +155     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengmk2 fengmk2 merged commit 0c4a52d into cnpm:master Dec 18, 2023
10 of 12 checks passed
fengmk2 pushed a commit that referenced this pull request Dec 18, 2023
[skip ci]

## [3.49.2](v3.49.1...v3.49.2) (2023-12-18)

### Bug Fixes

* should search default packages when text is empty ([#623](#623)) ([0c4a52d](0c4a52d))
fengmk2 pushed a commit that referenced this pull request Dec 19, 2023
[skip ci]

## [3.49.2](v3.49.1...v3.49.2) (2023-12-19)

### Bug Fixes

* ignore db query error default logger ([#626](#626)) ([6cc2f2d](6cc2f2d))
* should search default packages when text is empty ([#623](#623)) ([0c4a52d](0c4a52d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nodejs.ResponseError: x_content_parse_exception
3 participants